Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @qsi imports #323

Open
AaronBuxbaum opened this issue Sep 27, 2021 · 2 comments
Open

Remove @qsi imports #323

AaronBuxbaum opened this issue Sep 27, 2021 · 2 comments

Comments

@AaronBuxbaum
Copy link

import getNodes from '@qsi/common/lib/getNodes';

We're moving on to private GitHub Packages imports, so I'm not sure if these imports will work long-term. They're kind of questionable to begin with in a pseudo-circular import manner

@jquense
Copy link
Member

jquense commented Sep 28, 2021

I don't think this fixture resolves to anything, it's there to test linting I believe

@AaronBuxbaum
Copy link
Author

Ah hm... wouldn't it be better to make it clear that they're not real imports, then? Something like @fake removes (or at least reduces) needing to know that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants