Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent use of upper case in header fields and column names #34

Closed
strambc opened this issue Sep 15, 2022 · 2 comments · May be fixed by #35
Closed

Inconsistent use of upper case in header fields and column names #34

strambc opened this issue Sep 15, 2022 · 2 comments · May be fixed by #35
Assignees
@strambc @andreacosolo
Labels
help wanted Extra attention is needed high MAJOR CHANGE This is a proposed potential breaking change

Comments

@strambc
Copy link
Collaborator

strambc commented Sep 15, 2022 •
edited
Loading

POTENTIAL MAJOR/BREAKING CHANGE

The use of UPPER CASE in header fields and column names is inconsistent.
We should make it consistent.
@strambc strambc added help wanted Extra attention is needed high labels Sep 15, 2022
@andreacosolo
Copy link
Contributor

andreacosolo commented Sep 16, 2022 •
edited by strambc
Loading

Let's apply the same convention as for the column titles: Upper_Case_With_Underscores

@strambc
Copy link
Collaborator Author

strambc commented Sep 16, 2022 •
edited
Loading

DECISION: all Header Fields and Column names will follow the same convention: Upper_Case_With_Underscores

@andreacosolo andreacosolo linked a pull request Sep 26, 2022 that will close this issue
Breaking changes #35
Draft
@strambc strambc added the MAJOR CHANGE This is a proposed potential breaking change label Sep 26, 2022
@strambc strambc closed this as completed Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@strambc strambc

@andreacosolo andreacosolo

Labels
help wanted Extra attention is needed high MAJOR CHANGE This is a proposed potential breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Breaking changes 4dn-dcic/fish_omics_format
2 participants
@strambc @andreacosolo