Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.2 not compatible with ESP8266 3.1.* #2

Open
lathoub opened this issue Feb 20, 2023 · 1 comment
Open

v1.0.2 not compatible with ESP8266 3.1.* #2

lathoub opened this issue Feb 20, 2023 · 1 comment

Comments

@lathoub
Copy link

lathoub commented Feb 20, 2023

Hi,

I have noticed that the latest version of this library does not work with the 3.1.* version of the ESP8266 (but working fine with ESP8266 V3.0.2).
When you compile the v1.0.2 version on v3.1.1 you get this error:

/Users/**/Documents/Arduino/libraries/GFX4DIoD9/src/GFX4dIoD9.cpp: In member function 'void GFX4dIoD9::begin()':
/Users/**/Documents/Arduino/libraries/GFX4DIoD9/src/GFX4dIoD9.cpp:309:21: error: cannot convert 'SPISettings' to 'uint32_t' {aka 'unsigned int'}
  309 |   if (SD.begin(_sd, spiSettings))
      |                     ^~~~~~~~~~~
      |                     |
      |                     SPISettings

The issue came with this modif on the ESP8266 side: esp8266/Arduino@c487ca5 as part of the move to SdFat 2.0.2

Albeit advertised as non-breaking in https://github.com/esp8266/Arduino/releases/tag/3.1.0

A simple cast to uint32_t did not work.


Another issue is:

/Users/**/Documents/Arduino/libraries/GFX4DIoD9/src/GFX4dIoD9.cpp: In member function 'void GFX4dIoD9::ImageWifi(boolean, String, uint16_t, String, String)':
/Users/**/Documents/Arduino/libraries/GFX4DIoD9/src/GFX4dIoD9.cpp:1305:49: error: no matching function for call to 'HTTPClient::begin(String&, uint16_t&, String&, String&)'
 1305 |       if (!http.begin(Address, port, hfile, sha1)) return;
      |                                                 ^

Do these issue relate to the ESP8266 version check?
#if ARDUINO_ESP8266_GIT_VER > 0x2843a5ac

Thanks!

@lubolura
Copy link

lubolura commented Jun 8, 2024

I just started with IOD and I have same issue with :
309 | if (SD.begin(_sd, spiSettings))
| ^~~~~~~~~~~
| |
| SPISettings

Is there plan to fix it ? It seems I have to stop my work with IOD until it is not fixed ... or is there any way how to get around the problem ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants