Skip broken catalog brains in WorkflowSecurityUpdater. #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar as it was done for self.objects (see #146), we now also skip broken brains when updating workflow_security via `update_workflow_security`.
jone
suggested changes
Oct 8, 2018
| except KeyError: | ||
| return None | ||
|
|
||
| generator = (lookup(brain) for brain in brains) |
There was a problem hiding this comment.
I see two problems here:
- We are not uncataloging missing objects.
- This line does not filter
Noneelements, so the length of the SizedGenerator in the next line is too big when there are broken brains.
Could we move catalog_unrestricted_get_object from the step class into a place where we can reuse it here, so that we can use the same code?
I'd then use the same code as in #146:
generator = (self.catalog_unrestricted_get_object(brain) for brain in brains)
generator = (obj for obj in generator if obj is not None)
return SizedGenerator(generator, len(brains))
|
Was this implemented by 1ba13db? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar as it was done for self.objects (see #146), we now also skip broken brains when updating workflow_security via
update_workflow_security. This should help to have workflow updates without difficulties.