Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: performance graphs #59

Open
justadreamer opened this issue Jan 14, 2025 · 8 comments · Fixed by #60 or 51Degrees/common-ci#142
Open

go: performance graphs #59

justadreamer opened this issue Jan 14, 2025 · 8 comments · Fixed by #60 or 51Degrees/common-ci#142
Assignees

Comments

@justadreamer
Copy link
Contributor

justadreamer commented Jan 14, 2025

Motivation

Showcase the benchmarks for go.

Objective

Add running performance example for go and produce performance graphs nightly (Enrico action) like we do for other languages. To ultimately add them to documentation page https://51degrees.com/documentation/4.4/_benchmarks__device_detection.html - like we do for other languages.

@justadreamer
Copy link
Contributor Author

should be multiplied by 1000

@justadreamer justadreamer reopened this Jan 21, 2025
@pi-alexander-popel
Copy link
Contributor

@justadreamer
Copy link
Contributor Author

reverted the change in https://github.com/51Degrees/common-ci/blob/main/go/run-performance-tests.ps1#L35 and implemented a fix in go repo - will check the results tomorrow

@justadreamer justadreamer reopened this Jan 22, 2025
@justadreamer
Copy link
Contributor Author

@pi-alexander-popel the NIghtly PRs to Main seem to not be running for go repo could you please check https://github.com/51Degrees/device-detection-go/actions/runs/12830073543

@pi-alexander-popel
Copy link
Contributor

pi-alexander-popel commented Jan 23, 2025

That's because Package Update is disabled as there were no activity for 60 days. And PRs to Main has to be triggered by the Package Update.

@justadreamer
Copy link
Contributor Author

Nightly Package Update was disabled on both

re-enabled those, corrected performance reporting on the go level: 51Degrees/device-detection-examples-go#51, reverted the change on common-ci: 51Degrees/common-ci@679b78f

Let's wait several days until there are several artifacts

@justadreamer justadreamer self-assigned this Jan 27, 2025
@justadreamer
Copy link
Contributor Author

@justadreamer
Copy link
Contributor Author

let's tidy up the history of artifacts and release it to the website as a benchmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants