Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

English Version #24

Open
akmalelias opened this issue Oct 7, 2018 · 4 comments
Open

English Version #24

akmalelias opened this issue Oct 7, 2018 · 4 comments

Comments

@akmalelias
Copy link

Nice project but it will be good if you have English version. If you don't mind, can I create an English version of this project?
@52admln
Copy link
Owner

52admln commented Oct 8, 2018

Of course, it will be a nice work.

Looking forward to your English version of this project.

@akmalelias
Copy link
Author

Great! But how do you want it to be? Pull request to this repo or i create separate repo for English version but will credit to this repo. Because my concern is about all the commit messages and comments in the code. For label & display message in UI, we can create locale and resource bundle to support multi languages.

@52admln
Copy link
Owner

52admln commented Oct 8, 2018

To create separete repo looks like better.

@akmalelias
Copy link
Author

Ok will do. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@52admln @akmalelias