Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow dispatch #62

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

gitfool
Copy link

@gitfool gitfool commented Dec 8, 2021

Fixes #61.

@gitfool
Copy link
Author

gitfool commented Dec 8, 2021

@hannseman PTAL

@gitfool
Copy link
Author

gitfool commented Jan 10, 2022

@hannseman thoughts?

Copy link
Contributor

@flaeppe flaeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks. Could we add a test case that covers workflow dispatch handling?

@gitfool
Copy link
Author

gitfool commented Aug 22, 2022

@flaeppe Sounds like a good idea but I'm not a js/ts developer and don't have the bandwidth any more, sorry.

@amuresang
Copy link

Hello, I am trying to run this action with my cobertura.xml report:

- name: Generate cobertura report
        uses: 5monkeys/cobertura-action@v13
        with:
          path: ./test-reports/cobertura.xml
          minimum_coverage: 75

And i am getting:

Run 5monkeys/cobertura-action@v13
  with:
    path: ./test-reports/cobertura.xml
    minimum_coverage: 75
    repo_token: ***
    skip_covered: true
    fail_below_threshold: false
    show_line: false
    show_branch: false
    show_class_names: false
    show_missing: false
    link_missing_lines: false
    only_changed_files: false
  env:
    DEVELOPER_DIR: /Applications/Xcode_14.[2](https://github.com/MyiOSApp/actions/runs/6184469334/job/16788196695#step:25:2).app/Contents/Developer
    BUNDLER_VERSION: 1.17.2
    FASTLANE_USER: ***
    FASTLANE_PASSWORD: ***
    S[3](https://github.com/MyiOSApp/actions/runs/6184469334/job/16788196695#step:25:3)_BUCKET: myiosApp-applications
    S3_DIRECTORY: ios-hosting-internal
    SSH_AGENT_PID: 1810
Error: Found no commit.

Any thoughts?

@ShivaKumarKalvaTR
Copy link

@amuresang Your issue, is it resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Found no commit for workflow_dispatch event
4 participants