-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw an exception if both lazyMultiple
and multiple
are set
#106
Comments
When first skimming over the docs in the README, I assumed that I need to set both to have lazy, since multiple would be greedy by default. Handling it this way, since it might be closer to the expected behaviour, could of course also be an option. |
…ultiple` in aa0a3d4 I removed `multiple` from the `arr` option I didn't expect any change, but I was wrong. 75lb/command-line-args#106
Hi, sorry for the delay. The |
lazyMultiple
and multiple
are set
Hi. I send a pull request to fix this issue. It works, there is also a simple test. Should i do something more? Im noob. |
I know it's really an edge case since it can only happen when not reading the awesome documentation properly.
But since it's actually a contradiction according to the documentation and other similar things are also throwing an error, you might want to consider checking for this case and throwing an INVALID_DEFINITIONS error?
Alternatively it would make sense to just document which one wins, but if the issue is not reading docs... (hopefully this part doesn't already exist and I didn't spot it.)
The text was updated successfully, but these errors were encountered: