Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: "This sender already attached" Error when Connect right after Disconnect #19

Open
luongngocminh opened this issue Aug 5, 2024 · 2 comments
Open

Bug: "This sender already attached" Error when Connect right after Disconnect #19

luongngocminh opened this issue Aug 5, 2024 · 2 comments

Comments

@luongngocminh
Copy link
Contributor

image

Should do proper clean-up of the components

How to replicate:

  • Go into one of the samples, echo fast sample
  • Connect to server by pressing Connect button
  • Disconnect
  • Connect again
@jibon57
Copy link

jibon57 commented Aug 7, 2024

This is happening because sender was never cleaned. I proposed one solution long ago to do proper clean up after disconnect. https://github.com/jibon57/atm0s-media-sdk-js/blob/1e08284be9c511db5f998bc112e07c95e6cd5003/src/session.ts#L374C1-L394C23

@giangndm
Copy link
Contributor

giangndm commented Aug 7, 2024

@jibon57 @luongngocminh I think we should create new session in this case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jibon57 @luongngocminh @giangndm