From c86899d6b23f3435258efa94b7e9bbf64a49f365 Mon Sep 17 00:00:00 2001 From: Giang Minh Date: Thu, 21 Nov 2024 23:33:22 +0700 Subject: [PATCH] fix clippy --- packages/media_core/src/cluster/room/metadata.rs | 6 +++--- packages/media_runner/src/worker.rs | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/media_core/src/cluster/room/metadata.rs b/packages/media_core/src/cluster/room/metadata.rs index d0e066a6..1b8f29b8 100644 --- a/packages/media_core/src/cluster/room/metadata.rs +++ b/packages/media_core/src/cluster/room/metadata.rs @@ -250,7 +250,7 @@ impl RoomMetadata { None }; - let subscribers = self.peers_map_subscribers.iter().map(|a| a.clone()).collect::>(); + let subscribers = self.peers_map_subscribers.iter().copied().collect::>(); if let Some(info) = info { log::info!("[ClusterRoom {}] cluster: peer {} joined => fire event to {:?}", self.room, info.peer, subscribers); self.cluster_peers.insert(peer_key, info.clone()); @@ -273,7 +273,7 @@ impl RoomMetadata { None }; - let subscribers = self.tracks_map_subscribers.iter().map(|a| a.clone()).collect::>(); + let subscribers = self.tracks_map_subscribers.iter().copied().collect::>(); if let Some(info) = info { log::info!( "[ClusterRoom {}] cluster: peer ({}) started track {}) => fire event to {:?}", @@ -310,7 +310,7 @@ impl RoomMetadata { None }; - let subscribers = return_if_none!(self.peers_tracks_subs.get(&peer_map)).iter().map(|a| a.clone()).collect::>(); + let subscribers = return_if_none!(self.peers_tracks_subs.get(&peer_map)).iter().copied().collect::>(); if let Some(info) = info { log::info!( "[ClusterRoom {}] cluster: peer ({}) started track {}) => fire event to {:?}", diff --git a/packages/media_runner/src/worker.rs b/packages/media_runner/src/worker.rs index 402aa424..d2707a10 100644 --- a/packages/media_runner/src/worker.rs +++ b/packages/media_runner/src/worker.rs @@ -740,7 +740,7 @@ mod test { #[test] fn smallmap_collision() { - for i in 0..1000_000 { + for i in 0..1_000_000 { let mut map = indexmap::IndexMap::new(); let webrtc = MediaClusterEndpoint::Webrtc(WebrtcSession::from(rand::random::())); map.insert(webrtc, ()); @@ -753,11 +753,11 @@ mod test { map.swap_remove(&webrtc); assert_eq!(map.len(), 1); - assert_eq!(map.is_empty(), false, "first failsed, cycle {i} {webrtc:?} {rtpengine:?}"); + assert!(!map.is_empty(), "first failsed, cycle {i} {webrtc:?} {rtpengine:?}"); map.swap_remove(&rtpengine); assert_eq!(map.len(), 0); - assert_eq!(map.is_empty(), true, "second failsed, cycle {i} {webrtc:?} {rtpengine:?}"); + assert!(map.is_empty(), "second failsed, cycle {i} {webrtc:?} {rtpengine:?}"); } } }