Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: verify handshake when different timestamp with 2 node #10

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Fix: verify handshake when different timestamp with 2 node #10

merged 2 commits into from
Oct 10, 2024

Conversation

marverlous811
Copy link
Contributor

If the other node has a timestamp greater than the current node, the sharedKeyHandshake will throw an error handshake timeout. Because the formula current_ts - handshake_data.timestamp is negative and its type is u64 => its value is so large after convert => error handshake timeout

@giangndm
Copy link
Contributor

@marverlous811 It look good.

@giangndm giangndm merged commit 88fcc67 into 8xFF:main Oct 10, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giangndm giangndm giangndm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marverlous811 @giangndm