setup-environment - Cancel button not working

[zoltan-ongithub]

Steps to reproduce:

Run:

$ . setup-environment

Press "Cancel" during build target selection.

Issue: The setup scripts still continues. "Cancel" script seems to have undefined behaviour.

[ndechesne]

I quickly looked into that.. it's kind of not working 'by design'.. not sure what we want to do. for some reasons (which I don't know..) we have support for both whiptail and dialog tools. and we fallback from whiptail to dialog.

So when we hit cancel , we try the alternative option.. i agree that it's buggy in the sense that if you cancel the last alternative , it should abort and it doesn't..

from a user point of view , i think it's bad the way it's done. It's ok to support multiple backend tools, nothing wrong, but we should not fallback like that.

what I can propose is:

1. try whiptail or dialog (not both), e.g. try the one that is installed
2. implement a non graphical fallback in case none of them is installed

and if user hit cancel in step 1, then really cancel and abort immediately.

The other option is to remove the cancel button ;-)