strange symbols in generated code

[vtolstov]

unmarshalN__DirectiveLocation2ᚕstringᚄ

in generated file i can see strange symbols, does it possible to generate code only with standard symbols ?

my schema:

directive @AccountService on FIELD_DEFINITION
type Account {
	id: String
	parent: String
	zone: String
	status: AccountStatus
	login: String
	passw: String
	type: AccountType
	createdAt: Int
	updatedAt: Int
	deletedAt: Int
	info: AccountInfo
	metadata: [Account_MetadataEntry!]
}
enum AccountAddress {
	ACCOUNT_ADDRESS_UNSPECIFIED
	ACCOUNT_ADDRESS_REGISTRATION
	ACCOUNT_ADDRESS_CURRENT
	ACCOUNT_ADDRESS_CORPORATE
}
type AccountInfo {
	name: String
	email: String
	id: String
	contacts: [Contact!]
	addresses: [Address!]
}
enum AccountStatus {
	ACCOUNT_STATUS_UNSPECIFIED
	ACCOUNT_STATUS_DISABLED
	ACCOUNT_STATUS_ENABLED
	ACCOUNT_STATUS_BLOCKED
	ACCOUNT_STATUS_DELETED
}
enum AccountType {
	ACCOUNT_TYPE_UNSPECIFIED
	ACCOUNT_TYPE_PRIVATE
	ACCOUNT_TYPE_CORPORATE
}
type Account_MetadataEntry {
	key: String
	value: String
}
type Address {
	type: AccountAddress
	value: String
}
type Contact {
	type: ContactType
	value: String
}
enum ContactType {
	CONTACT_TYPE_UNSPECIFIED
	CONTACT_TYPE_EMAIL
	CONTACT_TYPE_PHONE
	CONTACT_TYPE_MESSENGER
}
input CreateAccountReqInput {
	name: String
}
type ListAccountRsp {
	accounts: [Account!]
}
type Mutation {
	accountServiceCreateAccount(in: CreateAccountReqInput): Boolean @AccountService
	accountServiceUpdateAccount: Boolean @AccountService
	accountServiceDeleteAccount: Boolean @AccountService
}
type Query {
	accountServiceListAccount: ListAccountRsp @AccountService
	accountServiceLookupAccount: Boolean @AccountService
}

[vtolstov]

func TypeIdentifier(t types.Type) string {
	res := ""
	for {
		switch it := code.Unalias(t).(type) {
		case *types.Pointer:
			t.Underlying()
			res += "ᚖ"
			t = it.Elem()
		case *types.Slice:
			res += "ᚕ"
			t = it.Elem()
		case *types.Named:
			res += pkgReplacer.Replace(it.Obj().Pkg().Path())
			res += "ᚐ"
			res += it.Obj().Name()
			return res
		case *types.Basic:
			res += it.Name()
			return res
		case *types.Map:
			res += "map"
			return res
		case *types.Interface:
			res += "interface"
			return res
		default:
			panic(fmt.Errorf("unexpected type %T", it))
		}
	}
}

[Brookke]

@vtolstov Is this causing an issue or is this just a style issue?

[vtolstov]

mostly this is style issue and i don't understand why we need to use such symbols (also my ci warns about non ascii symbols in code)

[Brookke]

Could replace the symbols in the TypeIdentifier here with words e.g.

func TypeIdentifier(t types.Type) string {
	res := ""
	for {
		switch it := code.Unalias(t).(type) {
		case *types.Pointer:
			t.Underlying()
			res += Pointer"
			t = it.Elem()
		case *types.Slice:
			res += "Slice"
			t = it.Elem()
		case *types.Named:
			res += pkgReplacer.Replace(it.Obj().Pkg().Path())
			res += "Named"
			res += it.Obj().Name()
			return res
		case *types.Basic:
			res += it.Name()
			return res
		case *types.Map:
			res += "Map"
			return res
		case *types.Interface:
			res += "Interface"
			return res
		default:
			panic(fmt.Errorf("unexpected type %T", it))
		}
	}
}

there is also

gqlgen/codegen/templates/templates.go

Lines 703 to 709 in e92956a

	var pkgReplacer = strings.NewReplacer(
	"/", "ᚋ",
	".", "ᚗ",
	"-", "ᚑ",
	"~", "א",
	)

but not sure what to propose as replacements here

[vtolstov]

may be this is time to change this?