Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeing changes to exec.go with Go 1.24.0 #3532

Open
carldunham opened this issue Feb 13, 2025 · 5 comments
Open

Seeing changes to exec.go with Go 1.24.0 #3532

carldunham opened this issue Feb 13, 2025 · 5 comments

Comments

@carldunham
Copy link
Contributor

The versions of exec.go are different in some places when generated with 1.24.0 vs 1.23.x versions. They don't seem to be functionally different, but break things like CI check for consistency.

We can work around this by pinning the Go version, but wondering if this is a known issue?

@StevenACoffman
Copy link
Collaborator

StevenACoffman commented Feb 15, 2025

Not really aware of that, so your report is helpful. Can you provide some more details?

@StevenACoffman
Copy link
Collaborator

@carldunham
I added Go v1.24.0 to the testing matrix and I'm not seeing any consistency problems in the exec.go in v0.17.65 so if you can please provide any examples (or even copy paste from some diff you see somewhere that you can't make more public), that might give more clues.

@carldunham
Copy link
Contributor Author

Ok, let me try a quick repro. If not, I can paste some snippets

@carldunham
Copy link
Contributor Author

No luck on this. I might suggest using StableSort for places like .Implementors, but I wasn't able to trigger anything different. It may be something in our environment, but can dig in a little there later this week.

@StevenACoffman
Copy link
Collaborator

Ok, let me know if you a. stop seeing this, or b. keep seeing it even if you can't figure out the cause

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants