Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player's Page - 'Map Performance' table can be very long/slow to load #20

Open
DNA-styx opened this issue Dec 22, 2024 · 0 comments
Open

Comments

@DNA-styx
Copy link

DNA-styx commented Dec 22, 2024

Describe the bug
The "Map performance" table displays every single map the player has played on all at once.
For servers with lots of maps this causes very slow loading times and an increase in SQL queries.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any HLStatsX web site that uses lots of maps
  2. Click on an active player
  3. Scroll down to their maps performance or click on 'Maps & Servers'
  4. Note that there is no pagination and there is no limit to the number of maps that are listed

Expected behavior
Pagination should be used to limit the map table and reduce load.

Screenshots
Some examples (remove OOO):
https://stats.niOOOde.gg/hlstats.php?mode=playerinfo&player=9503#
https://stats.unlOOOoze.com/hlstats.php?mode=playerinfo&player=109796#
http://hl.gamOOOers-global.com:8079/dashboard/hlstats.php?mode=playerinfo&player=20

Additional context
I've gone through a fir number of HLStatsX repos and can't find any mention of this issue or any updated code.

Looks like this issue has been in the code for a long time (unless I'm missing something huge)

I applied a very inelegant fix by limiting the SQL query on that page to 25.

Edit: This also affects the Maps page as well, which I presume uses the same table building code as the Player's Page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant