You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The "Map performance" table displays every single map the player has played on all at once.
For servers with lots of maps this causes very slow loading times and an increase in SQL queries.
To Reproduce
Steps to reproduce the behavior:
Go to any HLStatsX web site that uses lots of maps
Click on an active player
Scroll down to their maps performance or click on 'Maps & Servers'
Note that there is no pagination and there is no limit to the number of maps that are listed
Expected behavior
Pagination should be used to limit the map table and reduce load.
Describe the bug
The "Map performance" table displays every single map the player has played on all at once.
For servers with lots of maps this causes very slow loading times and an increase in SQL queries.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Pagination should be used to limit the map table and reduce load.
Screenshots
Some examples (remove OOO):
https://stats.niOOOde.gg/hlstats.php?mode=playerinfo&player=9503#
https://stats.unlOOOoze.com/hlstats.php?mode=playerinfo&player=109796#
http://hl.gamOOOers-global.com:8079/dashboard/hlstats.php?mode=playerinfo&player=20
Additional context
I've gone through a fir number of HLStatsX repos and can't find any mention of this issue or any updated code.
Looks like this issue has been in the code for a long time (unless I'm missing something huge)
I applied a very inelegant fix by limiting the SQL query on that page to 25.
Edit: This also affects the Maps page as well, which I presume uses the same table building code as the Player's Page.
The text was updated successfully, but these errors were encountered: