Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color displays as black if Horizon color is too low (Engine Bug) #2

Closed
ABelliqueux opened this issue Jun 24, 2021 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@ABelliqueux
Copy link
Owner

If Far color / Horizon color is < 100 (0.10 in blender), the corresponding channel color will display as black.

Example level0.c file :

CVECTOR level0_BGc = { 100, 218, 216, 0 };

results in :
2021-06-24-211924_682x505_scrot

CVECTOR level0_BGc = { 0, 218, 216, 0 };

2021-06-24-211901_685x506_scrot

Might be an error in the linear to RGB conversion function.

Also could be due to psyq dpq calculation. See LibRef47.pdf, p.450 and LibOver47.pdf, p.133, "Light Source Calculation" :

LLV = LLM * v0
LC = BK + LCM * LLV
v2 = (1 - p) * v1 * LC + p * FC
@ABelliqueux ABelliqueux added the bug Something isn't working label Jun 24, 2021
@ABelliqueux ABelliqueux self-assigned this Jun 24, 2021
@ABelliqueux ABelliqueux changed the title Color displays as black if Horizon color is too low Color displays as black if Horizon color is too low (Engine Bug) Jun 24, 2021
@ABelliqueux
Copy link
Owner Author

See here : ABelliqueux/3dcam-headers#1

ABelliqueux added a commit that referenced this issue Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant