Skip to content

Commit

Permalink
hw/usb/host-libusb: Get rid of qemu_open_old()
Browse files Browse the repository at this point in the history
For qemu_open_old(), osdep.h said:

> Don't introduce new usage of this function, prefer the following
> qemu_open/qemu_create that take an "Error **errp".

So replace qemu_open_old() with qemu_open().

Signed-off-by: Zhao Liu <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Reviewed-by: Michael Tokarev <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
  • Loading branch information
trueptolemy authored and Michael Tokarev committed Jul 17, 2024
1 parent 1a48869 commit a3c45ef
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions hw/usb/host-libusb.c
Original file line number Diff line number Diff line change
Expand Up @@ -1212,9 +1212,8 @@ static void usb_host_realize(USBDevice *udev, Error **errp)
if (s->hostdevice) {
int fd;
s->needs_autoscan = false;
fd = qemu_open_old(s->hostdevice, O_RDWR);
fd = qemu_open(s->hostdevice, O_RDWR, errp);
if (fd < 0) {
error_setg_errno(errp, errno, "failed to open %s", s->hostdevice);
return;
}
rc = usb_host_open(s, NULL, fd);
Expand Down

0 comments on commit a3c45ef

Please sign in to comment.