Skip to content

Commit

Permalink
target/i386/cpu: Mask off SGX/SGX_LC feature words for non-PC machine
Browse files Browse the repository at this point in the history
Only PC machine supports SGX, so mask off SGX related feature words for
non-PC machine (microvm).

Signed-off-by: Zhao Liu <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Paolo Bonzini <[email protected]>
  • Loading branch information
trueptolemy authored and bonzini committed Jul 31, 2024
1 parent 3722a98 commit ada1f3c
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 0 deletions.
5 changes: 5 additions & 0 deletions hw/i386/sgx-stub.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ void pc_machine_init_sgx_epc(PCMachineState *pcms)
memset(&pcms->sgx_epc, 0, sizeof(SGXEPCState));
}

bool check_sgx_support(void)
{
return false;
}

bool sgx_epc_get_section(int section_nr, uint64_t *addr, uint64_t *size)
{
return true;
Expand Down
8 changes: 8 additions & 0 deletions hw/i386/sgx.c
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,14 @@ void hmp_info_sgx(Monitor *mon, const QDict *qdict)
size);
}

bool check_sgx_support(void)
{
if (!object_dynamic_cast(qdev_get_machine(), TYPE_PC_MACHINE)) {
return false;
}
return true;
}

bool sgx_epc_get_section(int section_nr, uint64_t *addr, uint64_t *size)
{
PCMachineState *pcms =
Expand Down
1 change: 1 addition & 0 deletions include/hw/i386/sgx-epc.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ typedef struct SGXEPCState {
int nr_sections;
} SGXEPCState;

bool check_sgx_support(void);
bool sgx_epc_get_section(int section_nr, uint64_t *addr, uint64_t *size);
void sgx_epc_build_srat(GArray *table_data);

Expand Down
15 changes: 15 additions & 0 deletions target/i386/cpu.c
Original file line number Diff line number Diff line change
Expand Up @@ -6103,6 +6103,21 @@ uint64_t x86_cpu_get_supported_feature_word(X86CPU *cpu, FeatureWord w)
}
break;

case FEAT_7_0_EBX:
#ifndef CONFIG_USER_ONLY
if (!check_sgx_support()) {
unavail = CPUID_7_0_EBX_SGX;
}
#endif
break;
case FEAT_7_0_ECX:
#ifndef CONFIG_USER_ONLY
if (!check_sgx_support()) {
unavail = CPUID_7_0_ECX_SGX_LC;
}
#endif
break;

default:
break;
}
Expand Down

0 comments on commit ada1f3c

Please sign in to comment.