Skip to content

Commit

Permalink
hw/vfio/container: Get rid of qemu_open_old()
Browse files Browse the repository at this point in the history
For qemu_open_old(), osdep.h said:

> Don't introduce new usage of this function, prefer the following
> qemu_open/qemu_create that take an "Error **errp".

So replace qemu_open_old() with qemu_open().

Cc: Alex Williamson <[email protected]>
Cc: "Cédric Le Goater" <[email protected]>
Signed-off-by: Zhao Liu <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Reviewed-by: Cédric Le Goater <[email protected]>
Reviewed-by: Michael Tokarev <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
  • Loading branch information
trueptolemy authored and Michael Tokarev committed Jul 17, 2024
1 parent f80d59f commit eb92e6e
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions hw/vfio/container.c
Original file line number Diff line number Diff line change
Expand Up @@ -600,9 +600,8 @@ static bool vfio_connect_container(VFIOGroup *group, AddressSpace *as,
}
}

fd = qemu_open_old("/dev/vfio/vfio", O_RDWR);
fd = qemu_open("/dev/vfio/vfio", O_RDWR, errp);
if (fd < 0) {
error_setg_errno(errp, errno, "failed to open /dev/vfio/vfio");
goto put_space_exit;
}

Expand Down Expand Up @@ -743,9 +742,8 @@ static VFIOGroup *vfio_get_group(int groupid, AddressSpace *as, Error **errp)
group = g_malloc0(sizeof(*group));

snprintf(path, sizeof(path), "/dev/vfio/%d", groupid);
group->fd = qemu_open_old(path, O_RDWR);
group->fd = qemu_open(path, O_RDWR, errp);
if (group->fd < 0) {
error_setg_errno(errp, errno, "failed to open %s", path);
goto free_group_exit;
}

Expand Down

0 comments on commit eb92e6e

Please sign in to comment.