Skip to content

Commit

Permalink
hw/usb/u2f-passthru: Get rid of qemu_open_old()
Browse files Browse the repository at this point in the history
For qemu_open_old(), osdep.h said:

> Don't introduce new usage of this function, prefer the following
> qemu_open/qemu_create that take an "Error **errp".

So replace qemu_open_old() with qemu_open().

Signed-off-by: Zhao Liu <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Reviewed-by: Michael Tokarev <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
  • Loading branch information
trueptolemy authored and Michael Tokarev committed Jul 17, 2024
1 parent a3c45ef commit f80d59f
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions hw/usb/u2f-passthru.c
Original file line number Diff line number Diff line change
Expand Up @@ -482,10 +482,8 @@ static void u2f_passthru_realize(U2FKeyState *base, Error **errp)
return;
#endif
} else {
fd = qemu_open_old(key->hidraw, O_RDWR);
fd = qemu_open(key->hidraw, O_RDWR, errp);
if (fd < 0) {
error_setg(errp, "%s: Failed to open %s", TYPE_U2F_PASSTHRU,
key->hidraw);
return;
}

Expand Down

0 comments on commit f80d59f

Please sign in to comment.