Skip to content
This repository was archived by the owner on Jan 17, 2023. It is now read-only.

AFNetworking 2.2.x compatibility #79

Closed
chrisballinger opened this issue Apr 15, 2014 · 16 comments
Closed

AFNetworking 2.2.x compatibility #79

chrisballinger opened this issue Apr 15, 2014 · 16 comments

Comments

@chrisballinger
Copy link

I realize there are multiple issues open for AFNetworking 2.0 compatibility but it seems that there isn't much activity or interest in merging those patches. Is there any specific reason that these patches aren't acceptable?

I am developing a library/podspec that depends on both AFNetworking and AFOAuth2Client and I am worried that end users of the library may experience AFNetworking version conflicts. As far as I know, it isn't possible for me to point to an "unofficial" version of AFOAuth2Client in my podspec, so for now I guess I am limited to AFNetworking 1.3.x until the official podspec is updated as well.

@bmgdev
Copy link

bmgdev commented Jun 1, 2014

+1 here Chris -- cheers on kickflip.

@chrisballinger
Copy link
Author

Thanks! :)

@itavero
Copy link

itavero commented Jul 16, 2014

👍
This is used to be one of the cool things about AFNetworking: all the compatible libraries (like this one and AFIncrementalStore).
Unfortunately, most of them are not compatible with the latest version of AFNetworking.. 😒

@JoeCortopassi
Copy link

@mattt is this something you are open to someone else updating, or is this an abandoned project?

@nunofgs
Copy link

nunofgs commented Sep 9, 2014

Would love an update on this issue.

@mattt, any thoughts on this?

@markymc
Copy link

markymc commented Sep 10, 2014

@mattt Is this abandoned?

@face
Copy link

face commented Sep 26, 2014

+1 @mattt

I use [email protected]:mlwelles/AFOAuth2Client.git as a workaround, but would love to be able to use the official and not have warnings and outdated versions in my podfile etc.

@samskiter
Copy link

Perhaps someone else is up for the job of becoming the new owner of this project? I've only used it in one project so far so don't think I would be a great help... @conradev ?

@nunofgs
Copy link

nunofgs commented Oct 2, 2014

@samskiter We still don't know if this is abandoned.

@mattt is very active on github, nshipster, etc. Let's hope he responds to this thread.

@samskiter
Copy link

@nunofgs I think it might be safe to say this project is dead enough for someone to take some control and try and make some progress (presuming there is such a person who's prepared to take the task on - any volunteers? I'm probably not versed enough on AFNetworking 2.x to really contribute). I've experienced almost complete radio silence on issues/PR here since Dec 2013.

@bithavoc
Copy link

@matt 👍

@bdbergeron
Copy link

Hi everyone! I'm the creator/maintainer of the AFNetworking 2.0-compatible replacement for AFOAuth1Client, BDBOAuth1Manager. A new project I've started working on requires the use of OAuth 2.0, so I just wanted to gauge the community's interest in me creating an OAuth 2.0 version of BDBOAuth1Manager. Since I'm not familiar with the spec the way I am with OAuth 1.0a, it will take me a bit of time to get something working. If there's enough interest, I'm more than happy to throw it up here!

@conradev
Copy link
Contributor

The solution to updating AFOAuth2Client is not to change the code to get it to compile, because people have changed how they use AFNetworking in version 2.0. The solution isn't to write another library, either, because of backwards compatibility.

I have a fork of AFOAuth2Client that I feel conforms to the AFNetworking 2.0 way of doing things (minus renaming some of the methods on the class, which needs to be done). The client is ephemeral, the tokens persist to the keychain, and they can be added to the AFHTTPRequestSerialization pipeline of another client.

I have neglected to help maintain this project, but I am still one of the maintainers. I would love pull requests to my fork, and if it reaches a certain threshold, I can eventually move it to a branch here. Thoughts?

@mattt
Copy link
Contributor

mattt commented Nov 24, 2014

AFOAuth2Client has been deprecated in favor or AFOAuth2Manager, which is AFNetworking 2-compatible, integrating work from @conradev's branch.

pod 'AFNetworking', '~>2.5'
pod 'AFOAuth2Manager', '~>2.0'

For anyone still on AFNetworking 1.x, a new release of AFOAuth2Client, 1.0.0, has been pushed to CocoaPods.

pod 'AFNetworking', '~>1.3'
pod 'AFOAuth2Client', '~>1.0' # Deprecated

@chrisballinger
Copy link
Author

@mattt Awesome! Thank you!!

@haithngnbak
Copy link

thanks @mattt

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests