Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring #195

Open
mahaalbashir opened this issue Feb 8, 2024 · 0 comments
Open

Code refactoring #195

mahaalbashir opened this issue Feb 8, 2024 · 0 comments
Assignees

Comments

@mahaalbashir
Copy link
Contributor

Refactoring the function create_crosstab_masks in acro_table.

Looking at the levels of indentation and the numbers of lines in this method near where you calculate threshold masks etc., (lines 742 onwards) , I wonder if it is time to refactor some of this code into a series of functions called something like get_mask_for_aggfuncc()

@mahaalbashir mahaalbashir self-assigned this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant