Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize CSS files #4

Open
GokulNC opened this issue Feb 13, 2023 · 0 comments
Open

Generalize CSS files #4

GokulNC opened this issue Feb 13, 2023 · 0 comments
Assignees

Comments

@GokulNC
Copy link
Member

GokulNC commented Feb 13, 2023

After the PR #3, the CSS is now hardcoded inline, so that it works on NextJS for now.
We need to take it outside in the future updates.

Suggestions by Yash:

  • We could use something like Styled Components for React to write CSS separately in JSX files. But the CSS for indic-transliterate is hardly 20 lines so inline might be more suitable in this case
  • I could use a UI library for the package if you want, but I don't think that should be required with its current code size.

Creating this issue so that we do not forget this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants