Fix UB in SpiralIterator::operator++ (#481) (#489)

* Calling pop_back on an iterator past the end is UB Signed-off-by: Ryan Friedman <[email protected]> (cherry picked from commit 74dbbc8) Co-authored-by: Ryan <[email protected]>
ANYbotics · Nov 28, 2024 · 855a4ac · 855a4ac
1 parent 69c100f
commit 855a4ac
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/grid_map_core/src/iterators/SpiralIterator.cpp b/grid_map_core/src/iterators/SpiralIterator.cpp
@@ -66,6 +66,9 @@ const Eigen::Array2i & SpiralIterator::operator*() const
 
 SpiralIterator & SpiralIterator::operator++()
 {
+  if (isPastEnd()) {
+    return *this;
+  }
   pointsRing_.pop_back();
   if (pointsRing_.empty() && !isPastEnd()) {generateRing();}
   return *this;