Update a comment in avifImageYUVAnyToRGBAnySlow() #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following comment in avifImageYUVAnyToRGBAnySlow() // Monochrome: ... (identity mode is irrelevant) added in commit ca2c34d, was written when avifReformatMode had only two values (the default mode and identity mode). Now avifReformatMode has 3 values (or 5 if AVIF_ENABLE_EXPERIMENTAL_YCGCO_R is defined). Instead of enumerating all the non-default modes in the comment, just change "identity mode" to "state->mode".
wantehchang
commented
Aug 1, 2023
| @@ -763,7 +763,7 @@ static avifResult avifImageYUVAnyToRGBAnySlow(const avifImage * image, | |||
| G = Y - ((2 * ((kr * (1 - kr) * Cr) + (kb * (1 - kb) * Cb))) / kg); | |||
| } | |||
| } else { | |||
| // Monochrome: just populate all channels with luma (identity mode is irrelevant) | |||
| // Monochrome: just populate all channels with luma (state->mode is irrelevant) | |||
There was a problem hiding this comment.
Alternatively we could say "reformat mode is irrelevant". I use "state->mode" because the if (hasColor) code above (lines 735-764) uses different formulas depending on state->mode.
There was a problem hiding this comment.
i think the comment you have now is fine.
y-guyon
approved these changes
Aug 1, 2023
vigneshvg
approved these changes
Aug 1, 2023
| @@ -763,7 +763,7 @@ static avifResult avifImageYUVAnyToRGBAnySlow(const avifImage * image, | |||
| G = Y - ((2 * ((kr * (1 - kr) * Cr) + (kb * (1 - kb) * Cb))) / kg); | |||
| } | |||
| } else { | |||
| // Monochrome: just populate all channels with luma (identity mode is irrelevant) | |||
| // Monochrome: just populate all channels with luma (state->mode is irrelevant) | |||
There was a problem hiding this comment.
i think the comment you have now is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following comment in avifImageYUVAnyToRGBAnySlow()
// Monochrome: ... (identity mode is irrelevant)
added in commit ca2c34d, was written when avifReformatMode had only two values (the default mode and identity mode). Now avifReformatMode has 3 values (or 5 if AVIF_ENABLE_EXPERIMENTAL_YCGCO_R is defined). Instead of enumerating all the non-default modes in the comment, just change "identity mode" to "state->mode".