Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AVIF_ENABLE_EXPERIMENTAL_YCGCO_R=ON to CI #1490

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Add AVIF_ENABLE_EXPERIMENTAL_YCGCO_R=ON to CI #1490

merged 1 commit into from
Aug 7, 2023

Conversation

y-guyon
Copy link
Collaborator

@y-guyon y-guyon commented Aug 3, 2023

No description provided.

wantehchang
wantehchang approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The pull request contains seemingly unrelated changes.

It would be good to explain in the commit message how you chose the CI builds to have AVIF_ENABLE_EXPERIMENTAL_YCGCO_R=ON.

src/reformat.c
R = AVIF_CLAMP(B + Co, 0, state->rgbMaxChannel);
G = (float)AVIF_CLAMP(t + Cg, 0, state->rgbMaxChannel);
B = (float)AVIF_CLAMP(t - (Co >> 1), 0, state->rgbMaxChannel);
R = (float)AVIF_CLAMP(B + Co, 0, state->rgbMaxChannel);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should be moved to a separate CL.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #1495

@y-guyon
Copy link
Collaborator Author

y-guyon commented Aug 4, 2023

LGTM. The pull request contains seemingly unrelated changes.

The changes were to make the CI pass on Windows.

It would be good to explain in the commit message how you chose the CI builds to have AVIF_ENABLE_EXPERIMENTAL_YCGCO_R=ON.

It is good to test with and without AVIF_ENABLE_EXPERIMENTAL_YCGCO_R so I enabled it in a few diverse platforms.
I can add that to the commit message when rebasing after #1495.

@y-guyon y-guyon merged commit b415a2b into AOMediaCodec:main Aug 7, 2023
14 checks passed
@y-guyon y-guyon deleted the ci_ycgco_r branch September 5, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wantehchang wantehchang wantehchang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y-guyon @wantehchang