Print unprintable item->type in diagnostic message #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In avifDecoderGenerateImageGridTiles(), replace unprintable characters
in item->type with '.' and also print the hex values of item->type in
parentheses.
For example, if item->type is four NUL characters ('\0'), avifdec prints
the following diagnostic message:
Before:
Diagnostics:
* Tile item ID 5 has an unknown item type ''
After:
Diagnostics:
* Tile item ID 5 has an unknown item type '....' (0000 0000)
wantehchang
commented
Feb 7, 2024
| avifDiagnosticsPrintf(&decoder->diag, "Tile item ID %u has an unknown item type '%.4s'", item->id, (const char *)item->type); | ||
| char type[4]; | ||
| for (int j = 0; j < 4; j++) { | ||
| if (isprint((unsigned char)item->type[j])) { |
There was a problem hiding this comment.
The input argument to isprint() needs to be cast to unsigned char.
y-guyon
approved these changes
Feb 8, 2024
vigneshvg
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In avifDecoderGenerateImageGridTiles(), replace unprintable characters in item->type with '.' and also print the hex values of item->type in parentheses.
For example, if item->type is four NUL characters ('\0'), avifdec prints the following diagnostic message:
Before:
Diagnostics:
After:
Diagnostics: