Fix -Wextra-semi-stmt

[sezero]

empty expression statement has no effect; remove unnecessary ';' to silence this warning [-Werror,-Wextra-semi-stmt]

We noticed this in our libsdl fork. Applies to v1.0.x branch as is, as well.

[jzern]

This option could be added to CMakeLists.txt as well.

[sezero]

This option could be added to CMakeLists.txt as well.

Like this?

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 30644e8..ae1459b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -254,5 +254,5 @@ include(CheckCCompilerFlag)
 if(CMAKE_C_COMPILER_ID MATCHES "Clang")
     message(STATUS "libavif: Enabling warnings for Clang")
-    target_compile_options(avif_obj PUBLIC $<BUILD_INTERFACE:-Wall -Wextra -Wshorten-64-to-32>)
+    target_compile_options(avif_obj PUBLIC $<BUILD_INTERFACE:-Wall -Wextra -Wextra-semi-stmt -Wshorten-64-to-32>)
 elseif(CMAKE_C_COMPILER_ID MATCHES "GNU")
     message(STATUS "libavif: Enabling warnings for GCC")

It seems to be present in clang >= 8 and your cmake'ry doesn't seem to check versions.
Do you want me to add it nonetheless?

[wantehchang]

We can merge this pull request first. Either way is fine. Thank you for your contribution.

[sezero]

OK, merge as is, then. Thanks.

[jzern]

This option could be added to CMakeLists.txt as well.

Like this?

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 30644e8..ae1459b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -254,5 +254,5 @@ include(CheckCCompilerFlag)
 if(CMAKE_C_COMPILER_ID MATCHES "Clang")
     message(STATUS "libavif: Enabling warnings for Clang")
-    target_compile_options(avif_obj PUBLIC $<BUILD_INTERFACE:-Wall -Wextra -Wshorten-64-to-32>)
+    target_compile_options(avif_obj PUBLIC $<BUILD_INTERFACE:-Wall -Wextra -Wextra-semi-stmt -Wshorten-64-to-32>)
 elseif(CMAKE_C_COMPILER_ID MATCHES "GNU")
     message(STATUS "libavif: Enabling warnings for GCC")

It seems to be present in clang >= 8 and your cmake'ry doesn't seem to check versions. Do you want me to add it nonetheless?

Sorry about that. I figured there would be some extra work to check versions. We'll follow up with something. Thanks for the patch.