Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a presubmit workflow that runs fuzztest tests #2410

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

maryla-uc
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@y-guyon y-guyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see any fuzz test in the presubmit of this PR besides repro_avif_decode_fuzzer. Does ctest work with FuzzTest targets?

Is there an overlap on what is supposed to be tested with .github/workflows/cifuzz.yml?

.github/workflows/ci-linux-shared-local-fuzztest.yml Outdated Show resolved Hide resolved
@maryla-uc
Copy link
Collaborator Author

I do see a bunch of tests starting with "avif_fuzztest_" in the output?

There is no overlap with .github/workflows/cifuzz.yml, this one is ossfuzz and runs only the fuzzer in tests/oss-fuzz (which this one does not run) (yes this is all very simple...)

@vrabaud
Copy link
Collaborator

vrabaud commented Aug 27, 2024

Indeed, because CIFuzz does not handle fuzztest (cf google/oss-fuzz#11599), this CI is useful. I will remove CIFuzz inhttps://github.com//pull/2006 to merge it too.

Copy link
Collaborator

@y-guyon y-guyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do see a bunch of tests starting with "avif_fuzztest_" in the output?

Indeed, GitHub UI + Chrome search failed me. The logs are probably loaded lazily.

.github/workflows/ci-linux-shared-local-fuzztest.yml Outdated Show resolved Hide resolved
.github/workflows/ci-linux-shared-local-fuzztest.yml Outdated Show resolved Hide resolved
@maryla-uc maryla-uc merged commit a3647dc into AOMediaCodec:main Aug 27, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants