Disable JPEG finding in libyuv #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrabaud
changed the title
This is to prevent extra files in libyuv to be built and have a dependency order problem.
|
The windows CI problem is unrelated. |
wantehchang
reviewed
Oct 3, 2024
| @@ -34,6 +34,7 @@ else() | |||
| GIT_REPOSITORY "https://chromium.googlesource.com/libyuv/libyuv" | |||
| BINARY_DIR "${LIBYUV_BINARY_DIR}" | |||
| GIT_TAG "${AVIF_LOCAL_LIBYUV_TAG}" | |||
| PATCH_COMMAND sed -i.bak -e "s:find_package.*(.*JPEG.*)::" CMakeLists.txt | |||
There was a problem hiding this comment.
Vincent: Are you planning to submit a patch to libyuv to handle this properly?
Looking at the other build systems in the libyuv source tree, I think we should add a LIBYUV_DISABLE_JPEG option to libyuv's CMakeLists.txt file.
There was a problem hiding this comment.
No need actually, I reverted that patch: there is actually an official way to make find_package fail, cf #2473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevent extra files in libyuv to be built and have a dependency order problem.