Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable JPEG finding in libyuv #2459

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Disable JPEG finding in libyuv #2459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmake/Modules/LocalLibyuv.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ else()
GIT_REPOSITORY "https://chromium.googlesource.com/libyuv/libyuv"
BINARY_DIR "${LIBYUV_BINARY_DIR}"
GIT_TAG "${AVIF_LOCAL_LIBYUV_TAG}"
PATCH_COMMAND sed -i.bak -e "s:find_package.*(.*JPEG.*)::" CMakeLists.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vincent: Are you planning to submit a patch to libyuv to handle this properly?

Looking at the other build systems in the libyuv source tree, I think we should add a LIBYUV_DISABLE_JPEG option to libyuv's CMakeLists.txt file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need actually, I reverted that patch: there is actually an official way to make find_package fail, cf #2473

UPDATE_COMMAND ""
)

Expand Down
Loading