Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide remote users with feedback on last set of tunes #44

Open
jilavsky opened this issue Aug 10, 2020 · 2 comments
Open

Provide remote users with feedback on last set of tunes #44

jilavsky opened this issue Aug 10, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jilavsky
Copy link
Contributor

Remote users are completely blind to tuning. We are unable to provide them with any presentation of successful tunes. We should develop some kind. of feedback so they at least know what failed and something failed.
Options:

  1. web page with plots?
  2. PV for each tune with some report back to user? May be "OK" or written statement?
  3. Something smarter enabled by BS?
@jilavsky jilavsky added the enhancement New feature or request label Aug 10, 2020
@prjemian
Copy link
Contributor

When our tunes run in bluesky, the code assesses whether or not a peak was found:

    yield from axis.tune(md=md)
    yield from bps.mv(
        ti_filter_shutter, "close",
        scaler0.count_mode, "AutoCount",
    )

    found = axis.tuner.peak_detected()
    logger.info(f"axis: {axis.name}")
    logger.info(f"starting position: {axis_start}")
    logger.info(f"peak detected: {found}")
    if found:
        logger.info(f"  max: {axis.tuner.peaks.max}")
        logger.info(f"  center: {axis.tuner.peaks.cen}")
        logger.info(f"  centroid: {axis.tuner.peaks.com}")
        logger.info(f"  fwhm: {axis.tuner.peaks.fwhm}")
    logger.info(f"final position: {axis.position}")

This might be a place where we can add source such diagnostics. The name of the motor being tuned is provided in axis.name.

@prjemian
Copy link
Contributor

So, easiest would be a bo PV for each axis tuned that says peak found True or False.

A plot could be generated from the bluesky (tuning) run and could be placed in an axis-dependent plot (such as tune_mr.svg) on the livedata page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants