Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slope effects on weather module does not work when implemented at the simulation level above separate zones #9449

Open
MikeDoddNZ opened this issue Nov 15, 2024 · 1 comment · May be fixed by #9477
Open

Slope effects on weather module does not work when implemented at the simulation level above separate zones #9449

MikeDoddNZ opened this issue Nov 15, 2024 · 1 comment · May be fixed by #9477
Assignees
@ric394
Labels
Bug

Comments

@MikeDoddNZ
Copy link

What happened?

If implemented at the simulation level, with multiple zones having different aspects and slopes, slope effects does not distinguish these params between the zones. If those different aspects/slopes are implemented at the zone level, within separate simulations, it works OK. The attached sim file, with two sims and zones using similar slope/aspect params, demonstrates this. The overlap in output can be seen by viewing the charts using 'vary by sim' or 'vary by zone'.
test1.zip

What Operating System are you on?

Windows
@MikeDoddNZ MikeDoddNZ added the Bug label Nov 15, 2024
@ric394 ric394 moved this from Backlog to In progress in Apsim Initiative Software Bugs Nov 28, 2024
@ric394 ric394 self-assigned this Nov 28, 2024
@ric394
Copy link
Contributor

ric394 commented Nov 28, 2024 •
edited
Loading

There doesn't seem to be any handling in the model for multiple zones in it's current implementation, it will simply use the first Zone it finds.
For the moment I suggest this model has it's ValidParents changed to Zone until a solution is created that allows handling of Simulations with multiple Zones.

@ric394 ric394 linked a pull request Nov 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ric394 ric394

Labels
Bug
Projects
Apsim Initiative Software Bugs
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Simulation as valid parent for SlopeEffectOnWeather model ric394/ApsimX
2 participants
@MikeDoddNZ @ric394