Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS: Tests #100

Closed
mhubii opened this issue May 28, 2024 · 1 comment
Closed

JOSS: Tests #100

mhubii opened this issue May 28, 2024 · 1 comment

Comments

@mhubii
Copy link

mhubii commented May 28, 2024

Please always advise if incorrect.

First of all, I think there are plenty tests, which is great. I have a minor suggestion, but this might be personal preference.

The tests are somehow run via a shell script: https://github.com/ARC-OPT/wbc/blob/master/scripts/run_tests.sh

Is this common? I have only ever used gtest before and cmake for example provides ways to run these. I am afraid that having a shell script for that might miss some tests should further additions be made.

Refers openjournals/joss-reviews#6696

@dmronga
Copy link
Contributor

dmronga commented Jun 6, 2024

Fixed by #102

@dmronga dmronga closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants