Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and Upstream Merge #19

Merged
merged 10 commits into from
Apr 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/workflows/destroy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,5 @@ jobs:
with:
azcliversion: 2.30.0
inlineScript: |
az group delete --yes --name rg-avd-avdn-test-use2-pool-compute
az group delete --yes --name rg-avd-avdn-test-use2-service-objects
az group delete --yes --name rg-avd-avdn-test-use2-network
az group delete --yes --name rg-avd-avdn-test-use2-storage
az group delete --yes --name rg-avd-test-use2-monitoring

chmod +x $GITHUB_WORKSPACE/Delete_RGs.sh
$GITHUB_WORKSPACE/Delete_RGs.sh
12 changes: 12 additions & 0 deletions Delete_RGs.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
#! /bin/bash

# List of resource groups to delete
resource_groups=("rg-avd-avdn-test-use2-network" "rg-avd-avdn-test-use2-service-objects" "rg-avd-avdn-test-use2-pool-compute" "rg-avd-avdn-test-use2-storage" "rg-avd-test-use2-monitoring")

# Loop through each resource group and delete
for rg in "${resource_groups[@]}"; do
echo "Deleting resource group: $rg"
az group delete --name $rg --yes --no-wait
done

echo "Resource groups deletion requested. Check Azure portal for status."
4 changes: 2 additions & 2 deletions workload/arm/deploy-baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"_generator": {
"name": "bicep",
"version": "0.24.24.22086",
"templateHash": "11069848222764082779"
"templateHash": "2200290944314916056"
},
"name": "AVD Accelerator - Baseline Deployment",
"description": "AVD Accelerator - Deployment Baseline"
Expand Down Expand Up @@ -1516,7 +1516,7 @@
"IdentityServiceProvider": "[parameters('avdIdentityServiceProvider')]"
},
"varAvdDefaultTags": {
"cm-resource-parent": "[format('/subscriptions/{0}}}/resourceGroups/{1}/providers/Microsoft.DesktopVirtualization/hostpools/{2}', parameters('avdWorkloadSubsId'), variables('varServiceObjectsRgName'), variables('varHostPoolName'))]",
"cm-resource-parent": "[format('/subscriptions/{0}/resourceGroups/{1}/providers/Microsoft.DesktopVirtualization/hostpools/{2}', parameters('avdWorkloadSubsId'), variables('varServiceObjectsRgName'), variables('varHostPoolName'))]",
"Environment": "[parameters('deploymentEnvironment')]",
"ServiceWorkload": "AVD",
"CreationTimeUTC": "[parameters('time')]"
Expand Down
20 changes: 10 additions & 10 deletions workload/bicep/deploy-baseline-arpah.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -293,47 +293,47 @@ param avdServiceObjectsRgCustomName string = 'avd-nih-arpah-test-use2-service-ob

@maxLength(90)
@sys.description('AVD network resources resource group custom name. (Default: rg-avd-app1-dev-use2-network)')
param avdNetworkObjectsRgCustomName string = 'avd-nih-arpah-test-use2-network'
param avdNetworkObjectsRgCustomName string = 'rg-avd-avdn-test-use2-network'

@maxLength(90)
@sys.description('AVD network resources resource group custom name. (Default: rg-avd-app1-dev-use2-pool-compute)')
param avdComputeObjectsRgCustomName string = 'avd-nih-arpah-test-use2-pool-compute'

@maxLength(90)
@sys.description('AVD network resources resource group custom name. (Default: rg-avd-app1-dev-use2-storage)')
param avdStorageObjectsRgCustomName string = 'avd-nih-arpah-test-use2-storage'
param avdStorageObjectsRgCustomName string = 'rg-avd-avdn-test-use2-storage'

@maxLength(90)
@sys.description('AVD monitoring resource group custom name. (Default: rg-avd-dev-use2-monitoring)')
param avdMonitoringRgCustomName string = 'avd-nih-arpah-test-use2-monitoring'
param avdMonitoringRgCustomName string = 'rg-avd-test-use2-monitoring'

@maxLength(64)
@sys.description('AVD virtual network custom name. (Default: vnet-app1-dev-use2-001)')
param avdVnetworkCustomName string = 'vnet-app1-test-use2-001'
param avdVnetworkCustomName string = 'avd-nih-arpah-test-use2-vnet'

@maxLength(64)
@sys.description('AVD Azure log analytics workspace custom name. (Default: log-avd-app1-dev-use2)')
param avdAlaWorkspaceCustomName string = 'log-avd-app1-test-use2'
param avdAlaWorkspaceCustomName string = 'avd-nih-arpah-test-use2-log'

@maxLength(80)
@sys.description('AVD virtual network subnet custom name. (Default: snet-avd-app1-dev-use2-001)')
param avdVnetworkSubnetCustomName string = 'snet-avd-app1-test-use2-001'
param avdVnetworkSubnetCustomName string = 'avd-nih-arpah-test-use2-subnet'

@maxLength(80)
@sys.description('private endpoints virtual network subnet custom name. (Default: snet-pe-app1-dev-use2-001)')
param privateEndpointVnetworkSubnetCustomName string = 'snet-pe-app1-test-use2-001'
param privateEndpointVnetworkSubnetCustomName string = 'avd-nih-arpah-test-use2-subnet-private'

@maxLength(80)
@sys.description('AVD network security group custom name. (Default: nsg-avd-app1-dev-use2-001)')
param avdNetworksecurityGroupCustomName string = 'nsg-avd-app1-test-use2-001'
param avdNetworksecurityGroupCustomName string = 'avd-nih-arpah-test-use2-nsg'

@maxLength(80)
@sys.description('Private endpoint network security group custom name. (Default: nsg-pe-app1-dev-use2-001)')
param privateEndpointNetworksecurityGroupCustomName string = 'nsg-pe-app1-test-use2-001'
param privateEndpointNetworksecurityGroupCustomName string = 'avd-nih-arpah-test-use2-nsg-private'

@maxLength(80)
@sys.description('AVD route table custom name. (Default: route-avd-app1-dev-use2-001)')
param avdRouteTableCustomName string = 'route-avd-app1-test-use2-001'
param avdRouteTableCustomName string = 'avd-nih-arpah-test-use2-route'

@maxLength(80)
@sys.description('Private endpoint route table custom name. (Default: route-avd-app1-dev-use2-001)')
Expand Down
2 changes: 1 addition & 1 deletion workload/bicep/deploy-baseline.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@ var varAllComputeStorageTags = {
IdentityServiceProvider: avdIdentityServiceProvider
}
var varAvdDefaultTags = {
'cm-resource-parent': '/subscriptions/${avdWorkloadSubsId}}/resourceGroups/${varServiceObjectsRgName}/providers/Microsoft.DesktopVirtualization/hostpools/${varHostPoolName}'
'cm-resource-parent': '/subscriptions/${avdWorkloadSubsId}/resourceGroups/${varServiceObjectsRgName}/providers/Microsoft.DesktopVirtualization/hostpools/${varHostPoolName}'
Environment: deploymentEnvironment
ServiceWorkload: 'AVD'
CreationTimeUTC: time
Expand Down
Loading