Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge deployment branch to main #59

Merged
merged 124 commits into from
Dec 12, 2024
Merged

merge deployment branch to main #59

merged 124 commits into from
Dec 12, 2024

Conversation

jwaltireland
Copy link
Collaborator

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Replace me
  2. Replace me
  3. Replace me

Breaking Changes

  1. Replace me
  2. Replace me

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (AVD LZA Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

@jwaltireland
updated avdHostPoolRdpProperties param to support SSO
7dbd665
@jwaltireland
commented out antimalware ext and Add-MpPreference to test deployment
31802dc
@jwaltireland
need to download scxript from deployment branch, not main, for now
a50a41a
@jwaltireland
added ARPA-H AVD Default AD group for securityPrincipalName param
4f3ec96
@jwaltireland
added ARPA-H AVD Default AD group for securityPrincipalName param
9017a60
@jwaltireland
added updated storage account files
d8d538a
@jwaltireland
zipped up dsc storage scripts
a9535f3
@jwaltireland
reverted back to 1.0.0
8cbadf4
@jwaltireland
added logging for Script-DomainStorage call
67b0db6
@jwaltireland
added logging for Script-DomainStorage call
1f952c5
@jwaltireland
updates for deploying remote apps
cf6ac2c
@jwaltireland
updates for deploying remote apps
01c9149
@jwaltireland
updates for deploying remote apps
c6bbfaf
@jwaltireland
updates for deploying remote apps
3f93d27
@jwaltireland
updates for deploying remote apps
eaf0640
@jwaltireland
updates for deploying remote apps
54895c2
@jwaltireland
commented out remote apps, uncommented app installs
cb577b4
@jwaltireland
rezipped updated DSCStorageScripts.zip
f39c8f6
@jwaltireland
added remote app support
1525e9a
@jwaltireland
uncommented vmss and iaasantimalware, and commented out arpah networking
deb0d3a
@jwaltireland
uncommented vmss and iaasantimalware, and commented out arpah networking
b3111ca
@jwaltireland
Merge branch 'main' of https://github.com/ARPA-H/avdaccelerator-nih i…
f415845 
…nto deployment
@jwaltireland
pulled in ed's changes from PR, from main
b63957e
@jwaltireland
pulled in ed's changes from PR, from main
3723c91
@jwaltireland
commented out custom host pool mod
bbc01d9
@jwaltireland
changed kv prefix due to purge policy
76eb4d3
@jwaltireland
changed vm sku in params file
bcb5234
@jwaltireland
uncommented zonal properties
06f9f86
@jwaltireland
changed kv prefix
4ef6229
@jwaltireland
uncomment ext dependencies
88e1ead
@jwaltireland
deleted test file
af5dffb
@jwaltireland
uncommented tasks
90986a1
@jwaltireland
uncommented tasks
a5697d7
@jwaltireland
uncommented code
a1dc8c7
@jwaltireland
updates
5f2b262
@jwaltireland
updates
63a09fe
@jwaltireland
updates
5f5114e
@jwaltireland
removed version from image id
1789597
@jwaltireland
removed version from image id
3ed1c51
@jwaltireland
added new secret for imageGallerySubscriptionId
c5b4212
@jwaltireland
testing update networking gh job
560fcaa
@jwaltireland
testing update networking gh job
d6b623c
@jwaltireland
added code to existing loganalytics ws
578f973
@jwaltireland
updated vm name to use depl env letter
ce918bb
@jwaltireland
updated order for rg deletion
66285a7
@jwaltireland
added tolower
92fa097
@jwaltireland
added code for prod vm size
71894c6
@jwaltireland
set availabilityZonesCompute to false, to test
8c4a715
@jwaltireland
set availabilityZonesCompute back to true
4512b70
@jwaltireland
set availabilityZonesCompute back to true
9c893b8
@jwaltireland
added virtualMachineName to the deployment name to add distinction
95624fa
@jwaltireland
set failOnStdErr to false
b30a7b5
@jwaltireland
added gh env to destroy yaml
5485a5f
@jwaltireland
renamed kv
2c2f968
@jwaltireland
added av 2
e5bc3c6
@jwaltireland
added az
c05686a
@jwaltireland
gh secretized sec prin id and sec prin name for environments
0b5acc2
ed-rosario-arpa-h
ed-rosario-arpa-h approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@ed-rosario-arpa-h ed-rosario-arpa-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes have been tested in the deployment repository. Per request I briefly reviewed all changes so that it is merged to main

@jwaltireland jwaltireland merged commit 25e6949 into main Dec 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ed-rosario-arpa-h ed-rosario-arpa-h ed-rosario-arpa-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwaltireland @ed-rosario-arpa-h