From 422c4026c44497c4e1627d139f8f4141792c80e9 Mon Sep 17 00:00:00 2001
From: Jeroen Branje <info@jeroenbranje.nl>
Date: Wed, 6 Mar 2024 17:02:10 +0100
Subject: [PATCH] refactor(envited.ascs.digital): fix comments

Signed-off-by: Jeroen Branje <info@jeroenbranje.nl>
---
 .../src/components/Atoms/Button/Button.tsx           |  2 --
 apps/envited.ascs.digital/app/assets/detail/page.tsx |  2 --
 apps/envited.ascs.digital/app/assets/page.tsx        |  2 --
 apps/envited.ascs.digital/common/constants/index.ts  |  2 +-
 .../common/constants/navigations.ts                  |  7 +++++++
 apps/envited.ascs.digital/modules/Footer/Footer.tsx  |  6 +++---
 apps/envited.ascs.digital/modules/Header/Header.tsx  | 12 ++----------
 7 files changed, 13 insertions(+), 20 deletions(-)

diff --git a/apps/design-system/src/components/Atoms/Button/Button.tsx b/apps/design-system/src/components/Atoms/Button/Button.tsx
index b76f18f2..c4ca9f40 100644
--- a/apps/design-system/src/components/Atoms/Button/Button.tsx
+++ b/apps/design-system/src/components/Atoms/Button/Button.tsx
@@ -53,8 +53,6 @@ const Button: FC<Props> = ({
     },
   }
 
-  // 'flex w-full items-center justify-center rounded-md border border-transparent bg-indigo-600 px-8 py-3 text-base font-medium text-white hover:bg-indigo-700 focus:outline-none focus:ring-2 focus:ring-indigo-500 focus:ring-offset-2 focus:ring-offset-gray-50'
-
   const buttonView = isWorking ? <LoadingIndicator size={size} colour={indicatorColour[type][style]} /> : children
 
   return (
diff --git a/apps/envited.ascs.digital/app/assets/detail/page.tsx b/apps/envited.ascs.digital/app/assets/detail/page.tsx
index 47460455..1e60685b 100644
--- a/apps/envited.ascs.digital/app/assets/detail/page.tsx
+++ b/apps/envited.ascs.digital/app/assets/detail/page.tsx
@@ -9,5 +9,3 @@ export default async function Index() {
     </>
   )
 }
-
-export const dynamic = 'force-dynamic'
diff --git a/apps/envited.ascs.digital/app/assets/page.tsx b/apps/envited.ascs.digital/app/assets/page.tsx
index 52c28a7b..2b854161 100644
--- a/apps/envited.ascs.digital/app/assets/page.tsx
+++ b/apps/envited.ascs.digital/app/assets/page.tsx
@@ -9,5 +9,3 @@ export default async function Index() {
     </>
   )
 }
-
-export const dynamic = 'force-dynamic'
diff --git a/apps/envited.ascs.digital/common/constants/index.ts b/apps/envited.ascs.digital/common/constants/index.ts
index 619b5839..bfd4a4eb 100644
--- a/apps/envited.ascs.digital/common/constants/index.ts
+++ b/apps/envited.ascs.digital/common/constants/index.ts
@@ -1,6 +1,6 @@
 export { ERRORS } from './errors'
 export { RESPONSES } from './response'
-export { NAVIGATION_DASHBOARD } from './navigations'
+export { NAVIGATION, NAVIGATION_DASHBOARD } from './navigations'
 
 export const MINIMUM_PROFILE_REQUIREMENTS = ['name', 'category', 'logo', 'description']
 export const RESTRICTED_PROFILE_FIELDS = ['principalName', 'principalPhone', 'principalEmail']
diff --git a/apps/envited.ascs.digital/common/constants/navigations.ts b/apps/envited.ascs.digital/common/constants/navigations.ts
index 57d93ca7..0e61345f 100644
--- a/apps/envited.ascs.digital/common/constants/navigations.ts
+++ b/apps/envited.ascs.digital/common/constants/navigations.ts
@@ -1,5 +1,12 @@
 import { ROUTES } from './routes'
 
+export const NAVIGATION = [
+  { name: 'Home', href: '/' },
+  { name: 'Assets', href: '/assets' },
+  { name: 'Members', href: '/members' },
+  { name: 'Contact', href: '#' },
+]
+
 export const NAVIGATION_DASHBOARD = [
   {
     href: ROUTES.DASHBOARD.HOME,
diff --git a/apps/envited.ascs.digital/modules/Footer/Footer.tsx b/apps/envited.ascs.digital/modules/Footer/Footer.tsx
index b7f0891f..d064bbbb 100644
--- a/apps/envited.ascs.digital/modules/Footer/Footer.tsx
+++ b/apps/envited.ascs.digital/modules/Footer/Footer.tsx
@@ -1,6 +1,6 @@
 import { useTranslation } from 'apps/envited.ascs.digital/common/i18n'
 import Image from 'next/image'
-import { FC } from 'react'
+import { FC, SVGProps } from 'react'
 
 export interface FooterProps {}
 
@@ -20,7 +20,7 @@ const navigation = {
     {
       name: 'X',
       href: '#',
-      icon: (props: any) => (
+      icon: (props: SVGProps<SVGSVGElement>) => (
         <svg fill="currentColor" viewBox="0 0 24 24" {...props}>
           <path d="M13.6823 10.6218L20.2391 3H18.6854L12.9921 9.61788L8.44486 3H3.2002L10.0765 13.0074L3.2002 21H4.75404L10.7663 14.0113L15.5685 21H20.8131L13.6819 10.6218H13.6823ZM11.5541 13.0956L10.8574 12.0991L5.31391 4.16971H7.70053L12.1742 10.5689L12.8709 11.5655L18.6861 19.8835H16.2995L11.5541 13.096V13.0956Z" />
         </svg>
@@ -29,7 +29,7 @@ const navigation = {
     {
       name: 'GitHub',
       href: '#',
-      icon: (props: any) => (
+      icon: (props: SVGProps<SVGSVGElement>) => (
         <svg fill="currentColor" viewBox="0 0 24 24" {...props}>
           <path
             fillRule="evenodd"
diff --git a/apps/envited.ascs.digital/modules/Header/Header.tsx b/apps/envited.ascs.digital/modules/Header/Header.tsx
index 541166b4..c93cd3a7 100644
--- a/apps/envited.ascs.digital/modules/Header/Header.tsx
+++ b/apps/envited.ascs.digital/modules/Header/Header.tsx
@@ -5,22 +5,14 @@ import Image from 'next/image'
 import Link from 'next/link'
 import { FC } from 'react'
 
+import { NAVIGATION } from '../../common/constants'
 import { useTranslation } from '../../common/i18n'
 
-// import { ThemeToggle } from '../ThemeToggle'
-
 export interface HeaderProps {}
 
 export const Header: FC<HeaderProps> = () => {
   const { t } = useTranslation('Header')
 
-  const navigation = [
-    { name: 'Home', href: '/' },
-    { name: 'Assets', href: '/assets' },
-    { name: 'Members', href: '/members' },
-    { name: 'Contact', href: '#' },
-  ]
-
   return (
     <header className="py-10">
       <div className="mx-auto max-w-7xl px-4 sm:px-6 lg:px-8">
@@ -31,7 +23,7 @@ export const Header: FC<HeaderProps> = () => {
             </Link>
           </div>
           <div className="hidden lg:flex lg:gap-x-12 lg:items-center">
-            {navigation.map(item => (
+            {NAVIGATION.map(item => (
               <a key={item.name} href={item.href} className="text-sm font-semibold leading-6 text-gray-900">
                 {item.name}
               </a>