Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github workflows and delete pull request template #72

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

jtherrmann
Copy link
Contributor

@jtherrmann jtherrmann commented Jun 28, 2024

We should see if we can fix this cfn-lint warning before merging all the way to develop:

W3045 'AccessControl' is a legacy property. Consider using 'AWS::S3::BucketPolicy' instead
cloudformation.yml:22:7

@jtherrmann jtherrmann requested a review from a team June 28, 2024 23:30
@jtherrmann jtherrmann marked this pull request as draft June 28, 2024 23:33
@jtherrmann jtherrmann marked this pull request as ready for review June 28, 2024 23:34
with:
local_package_names: api,database,find_new,harvest_products

cfn-lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2

- uses: scottbrenner/cfn-lint-action@master

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtherrmann jtherrmann merged commit 4c63bf2 into deprecate_python38 Jul 1, 2024
2 of 3 checks passed
@jtherrmann jtherrmann deleted the actions branch July 1, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants