From c450599b5a199a85cead506c1b96276733e070d5 Mon Sep 17 00:00:00 2001
From: Ion Koutsouris <15728914+ion-elgreco@users.noreply.github.com>
Date: Wed, 22 Jan 2025 13:38:21 +0100
Subject: [PATCH] chore: better types (#18)

---
 dagster_uc/manage_user_code_deployments.py | 3 ++-
 dagster_uc/uc_handler.py                   | 6 +++---
 pyproject.toml                             | 6 +++---
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/dagster_uc/manage_user_code_deployments.py b/dagster_uc/manage_user_code_deployments.py
index db5b86b..39400fc 100644
--- a/dagster_uc/manage_user_code_deployments.py
+++ b/dagster_uc/manage_user_code_deployments.py
@@ -8,7 +8,7 @@
 import subprocess
 import time
 from dataclasses import asdict
-from typing import Annotated
+from typing import Annotated, cast
 
 import kr8s
 import typer
@@ -317,6 +317,7 @@ def check_deployment(
         label_selector=f"deployment={name}",
         namespace=config.namespace,
     ):
+        pod = cast(Pod, pod)
         with contextlib.suppress(Exception):
             for line in pod.logs(pretty=True, follow=True, timeout=timeout):  # type: ignore
                 typer.echo(line)
diff --git a/dagster_uc/uc_handler.py b/dagster_uc/uc_handler.py
index ffef581..f76b28f 100644
--- a/dagster_uc/uc_handler.py
+++ b/dagster_uc/uc_handler.py
@@ -74,7 +74,7 @@ def remove_all_deployments(self) -> None:
         configmap = self._read_namespaced_config_map(
             self.config.user_code_deployments_configmap_name,
         )
-        configmap.patch(dagster_user_deployments_values_yaml_configmap)  # type: ignore
+        configmap.patch(dagster_user_deployments_values_yaml_configmap)
 
     def list_deployments(
         self,
@@ -240,7 +240,7 @@ def delete_k8s_resources_for_user_deployment(
             namespace=self.config.namespace,
         ):
             logger.info(f"Deleting pod {pod.name}")
-            pod.delete()  # type: ignore
+            pod.delete()
 
         if delete_deployments:
             import contextlib
@@ -499,7 +499,7 @@ def delete_k8s_resources(self, label_selector: str):
                 namespace=self.config.namespace,
                 label_selector=label_selector,
             ):
-                item.delete()  # type: ignore
+                item.delete()
 
     def acquire_semaphore(self, reset_lock: bool = False) -> bool:
         """Acquires a semaphore by creating a configmap"""
diff --git a/pyproject.toml b/pyproject.toml
index 4866ff4..b4f027e 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -17,9 +17,9 @@ classifiers = [
     "Programming Language :: Python :: 3.13"
 ]
 dependencies = [
-    "kr8s>=0.20,<1.0",
-    "pyhelm3==0.3.3",
-    "typer==0.12.3",
+    "kr8s>=0.20.1,<1.0",
+    "pyhelm3>=0.3.3",
+    "typer>=0.15.1",
     "tomli",
     "pyyaml",
     "pytz"