From 0d59ed8aac61c9035adeb5371c0c265b5d23c6b5 Mon Sep 17 00:00:00 2001 From: Ion Koutsouris <15728914+ion-elgreco@users.noreply.github.com> Date: Fri, 31 Jan 2025 10:28:28 +0100 Subject: [PATCH 1/4] perf: use IfNotPresent pullpolicy --- dagster_uc/uc_handler.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dagster_uc/uc_handler.py b/dagster_uc/uc_handler.py index 19c8c34..85669e7 100644 --- a/dagster_uc/uc_handler.py +++ b/dagster_uc/uc_handler.py @@ -277,7 +277,7 @@ def gen_new_deployment_yaml( name, ), "tag": tag, - "pullPolicy": "Always", + "pullPolicy": "IfNotPresent", # Safe, due to versioning of each deployment image }, "dagsterApiGrpcArgs": [ "-f", From 9e0322589c943213e568f5e16b0985cdc7793bb8 Mon Sep 17 00:00:00 2001 From: Ion Koutsouris <15728914+ion-elgreco@users.noreply.github.com> Date: Fri, 31 Jan 2025 10:28:46 +0100 Subject: [PATCH 2/4] chore: bump python --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index bf6a764..81a52fe 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [project] name = "dagster-uc" -version = "0.3.3" +version = "0.3.4" authors = [ {name = "Stefan Verbruggen"}, {name = "Ion Koutsouris"}, From 0c5ab27207ed1a3b09ad20deeee67c111ead2340 Mon Sep 17 00:00:00 2001 From: Ion Koutsouris <15728914+ion-elgreco@users.noreply.github.com> Date: Fri, 31 Jan 2025 10:36:45 +0100 Subject: [PATCH 3/4] chore: fmt --- dagster_uc/uc_handler.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dagster_uc/uc_handler.py b/dagster_uc/uc_handler.py index 85669e7..23fe8c7 100644 --- a/dagster_uc/uc_handler.py +++ b/dagster_uc/uc_handler.py @@ -277,7 +277,7 @@ def gen_new_deployment_yaml( name, ), "tag": tag, - "pullPolicy": "IfNotPresent", # Safe, due to versioning of each deployment image + "pullPolicy": "IfNotPresent", # Safe, due to versioning of each deployment image }, "dagsterApiGrpcArgs": [ "-f", From fabdf12de070197b82ddcd8ac49a6f0504c7ffd7 Mon Sep 17 00:00:00 2001 From: Ion Koutsouris <15728914+ion-elgreco@users.noreply.github.com> Date: Fri, 31 Jan 2025 10:42:43 +0100 Subject: [PATCH 4/4] fix: ci --- .github/workflows/CI.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 8d21f20..54faa6c 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -61,7 +61,7 @@ jobs: - name: Build a binary wheel run: uv build . - name: Store the distribution packages - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: python-package-distributions path: dist/ @@ -79,7 +79,7 @@ jobs: steps: - name: Download all the dists - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: python-package-distributions path: my_dists/