Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use IfNotPresent pull policy #21

Merged
merged 4 commits into from
Jan 31, 2025
Merged

perf: use IfNotPresent pull policy #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d59ed8
perf: use IfNotPresent pullpolicy
ion-elgreco Jan 31, 2025
9e03225
chore: bump python
ion-elgreco Jan 31, 2025
0c5ab27
chore: fmt
ion-elgreco Jan 31, 2025
fabdf12
fix: ci
ion-elgreco Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
- name: Build a binary wheel
run: uv build .
- name: Store the distribution packages
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: python-package-distributions
path: dist/
Expand All @@ -79,7 +79,7 @@ jobs:

steps:
- name: Download all the dists
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: python-package-distributions
path: my_dists/
Expand Down
2 changes: 1 addition & 1 deletion dagster_uc/uc_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ def gen_new_deployment_yaml(
name,
),
"tag": tag,
"pullPolicy": "Always",
"pullPolicy": "IfNotPresent", # Safe, due to versioning of each deployment image
},
"dagsterApiGrpcArgs": [
"-f",
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "dagster-uc"
version = "0.3.3"
version = "0.3.4"
authors = [
{name = "Stefan Verbruggen"},
{name = "Ion Koutsouris"},
Expand Down