[#3] - Solução para o problema dos múltiplos warnings #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipebraida
requested changes
Aug 19, 2020
| @@ -35,12 +35,14 @@ end | |||
| #TODO: Verificar se tem colunas duplicatas | |||
| FilterModifier(columns::Symbol...) = FilterModifier([columns...]) | |||
|
|
|||
| const EasyWarnings = Set() | |||
There was a problem hiding this comment.
Problema que esse aviso fica armazenado no módulo. Caso a pessoa crie um novo stream, ela não vai ser avisada. Outra parada, o Set eu acho que é imutável. Dá uma conferida nisso.
There was a problem hiding this comment.
Poderíamos tornar esse warn checker um atributo do Stream e em determinados procedimentos limpamos ele pra evitar que isso acabe inibindo o aviso de um futuro erro. Vou pensar mais um pouco nesse problema.
There was a problem hiding this comment.
Acho que teria que ser ... Problema que você nunca sabe o que está vindo.
| @@ -35,12 +35,14 @@ end | |||
| #TODO: Verificar se tem colunas duplicatas | |||
| FilterModifier(columns::Symbol...) = FilterModifier([columns...]) | |||
|
|
|||
| const EasyWarnings = Set() | |||
| warn(str::String, warnChecker::Set) = str in warnChecker || (@warn str) == nothing && push!(warnChecker, str) | |||
There was a problem hiding this comment.
Na verdade seria String ou Symbol. Tem que conferir se no dataframe o nome da coluna sempre vem em Symbol. Se for é symbol aqui.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.