From 63a2257a61fb08801cb88cd1e732d747b71dfb77 Mon Sep 17 00:00:00 2001
From: Sebastian Leidig <sebastian@aam-digital.com>
Date: Sat, 18 Jan 2025 16:52:23 +0100
Subject: [PATCH] better i18n tags

---
 .../notes-dashboard/notes-dashboard.component.html   | 11 ++++++-----
 .../admin-entity-form.component.html                 |  5 +++--
 .../admin-entity-list.component.html                 | 12 ++++++------
 .../setup-wizard-button.component.html               |  3 +--
 src/app/core/ui/ui/ui.component.html                 | 12 +++---------
 .../coming-soon/coming-soon.component.html           | 12 +++++++-----
 .../template-export-selection-dialog.component.html  | 11 +++++++----
 .../edit-recurring-interval.component.html           |  6 ++----
 8 files changed, 35 insertions(+), 37 deletions(-)

diff --git a/src/app/child-dev-project/notes/dashboard-widgets/notes-dashboard/notes-dashboard.component.html b/src/app/child-dev-project/notes/dashboard-widgets/notes-dashboard/notes-dashboard.component.html
index 887faead93..ce705d495a 100644
--- a/src/app/child-dev-project/notes/dashboard-widgets/notes-dashboard/notes-dashboard.component.html
+++ b/src/app/child-dev-project/notes/dashboard-widgets/notes-dashboard/notes-dashboard.component.html
@@ -20,11 +20,12 @@
         </td>
       </ng-container>
 
-      <ng-container
-        matColumnDef="daysSinceLastNote"
-        i18n="Amount of days back|Format like 'Days passed > 5 days'"
-      >
-        <td *matCellDef="let entityNoteInfo" class="text-align-end">
+      <ng-container matColumnDef="daysSinceLastNote">
+        <td
+          *matCellDef="let entityNoteInfo"
+          class="text-align-end"
+          i18n="Amount of days back|Format like 'Days passed > 5 days'"
+        >
           <ng-container *ngIf="entityNoteInfo.moreThanDaysSince">
             &gt;&nbsp;
           </ng-container>
diff --git a/src/app/core/admin/admin-entity-details/admin-entity-form/admin-entity-form.component.html b/src/app/core/admin/admin-entity-details/admin-entity-form/admin-entity-form.component.html
index 1045b4e6be..9c369a90f9 100644
--- a/src/app/core/admin/admin-entity-details/admin-entity-form/admin-entity-form.component.html
+++ b/src/app/core/admin/admin-entity-details/admin-entity-form/admin-entity-form.component.html
@@ -74,9 +74,10 @@
         cdkDropList
         (cdkDropListDropped)="dropNewGroup($event)"
         class="fields-group-list drop-list drop-area-hint"
-        i18n="Header of drag and drop box"
       >
-        drop here to create new field group
+        <span i18n="Header of drag and drop box"
+          >drop here to create new field group</span
+        >
         <fa-icon
           icon="question-circle"
           matTooltip="You can group fields so that they will always appear next to each other while the layout is automatically adjusted to different screen sizes. Such field groups can also have a title displayed to users."
diff --git a/src/app/core/admin/admin-entity-list/admin-entity-list.component.html b/src/app/core/admin/admin-entity-list/admin-entity-list.component.html
index 07403c26ea..9a50a00369 100644
--- a/src/app/core/admin/admin-entity-list/admin-entity-list.component.html
+++ b/src/app/core/admin/admin-entity-list/admin-entity-list.component.html
@@ -29,8 +29,8 @@
       <div cdkDrag class="filter-field drop-item flex-row gap-small">
         <fa-icon icon="grip-vertical" size="xl" class="drag-handle"></fa-icon>
         <mat-form-field appearance="fill">
-          <mat-label
-            ><app-entity-field-label
+          <mat-label>
+            <app-entity-field-label
               [field]="filter"
               [entityType]="entityConstructor"
             ></app-entity-field-label>
@@ -47,8 +47,8 @@
     </div>
   </div>
 
-  <div class="table-content-preview" i18n>
-    Add Filter:
+  <div class="table-content-preview">
+    <span i18n>Add Filter:</span>
     <app-entity-fields-menu
       [entityType]="entityConstructor"
       [activeFields]="filters"
@@ -91,8 +91,8 @@
         }
       </div>
 
-      <div class="table-content-preview" i18n>
-        Drag & drop table column headers. Add columns:
+      <div class="table-content-preview">
+        <span i18n>Drag & drop table column headers. Add columns:</span>
         <app-entity-fields-menu
           [entityType]="entityConstructor"
           [(activeFields)]="item.columns"
diff --git a/src/app/core/admin/setup-wizard/setup-wizard-button/setup-wizard-button.component.html b/src/app/core/admin/setup-wizard/setup-wizard-button/setup-wizard-button.component.html
index 602d53522a..4ddad45f0d 100644
--- a/src/app/core/admin/setup-wizard/setup-wizard-button/setup-wizard-button.component.html
+++ b/src/app/core/admin/setup-wizard/setup-wizard-button/setup-wizard-button.component.html
@@ -5,9 +5,8 @@
     class="button"
     color="accent"
     style="border-radius: 0"
-    i18n
   >
     <fa-icon icon="person-digging"></fa-icon>
-    Setup Wizard
+    <span i18n>Setup Wizard</span>
   </button>
 }
diff --git a/src/app/core/ui/ui/ui.component.html b/src/app/core/ui/ui/ui.component.html
index ee9fa0e877..23fae56dbc 100644
--- a/src/app/core/ui/ui/ui.component.html
+++ b/src/app/core/ui/ui/ui.component.html
@@ -91,21 +91,15 @@
             (click)="closeSidenavOnMobile()"
             mat-button
             routerLink="user-account"
-            i18n="Navigate to user profile page"
             class="footer-cell width-1-2"
           >
             <fa-icon icon="user"></fa-icon>
-            Profile
+            <span i18n="Navigate to user profile page">Profile</span>
           </button>
 
-          <button
-            mat-button
-            (click)="logout()"
-            i18n="Sign out of the app"
-            class="footer-cell width-1-2"
-          >
+          <button mat-button (click)="logout()" class="footer-cell width-1-2">
             <fa-icon icon="sign-out-alt"></fa-icon>
-            Sign out
+            <span i18n="Sign out of the app">Sign out</span>
           </button>
         </div>
 
diff --git a/src/app/features/coming-soon/coming-soon/coming-soon.component.html b/src/app/features/coming-soon/coming-soon/coming-soon.component.html
index bff91c361f..8145079b62 100644
--- a/src/app/features/coming-soon/coming-soon/coming-soon.component.html
+++ b/src/app/features/coming-soon/coming-soon/coming-soon.component.html
@@ -13,13 +13,15 @@ <h3 i18n="Coming Soon description">
       class="full-width"
       (click)="reportFeatureRequest()"
       [disabled]="requested"
-      i18n="
-        Feature Button|Indicates that the user needs this feature and can send a
-        feature-request
-      "
     >
       <fa-icon *ngIf="requested" aria-label="requested" icon="check"></fa-icon>
-      I need this feature
+      <span
+        i18n="
+          Feature Button|Indicates that the user needs this feature and can send
+          a feature-request
+        "
+        >I need this feature</span
+      >
     </button>
 
     <a
diff --git a/src/app/features/template-export/template-export-selection-dialog/template-export-selection-dialog.component.html b/src/app/features/template-export/template-export-selection-dialog/template-export-selection-dialog.component.html
index 21ce8cc1e6..ee01e31eeb 100644
--- a/src/app/features/template-export/template-export-selection-dialog/template-export-selection-dialog.component.html
+++ b/src/app/features/template-export/template-export-selection-dialog/template-export-selection-dialog.component.html
@@ -1,8 +1,10 @@
 <mat-dialog-content>
   <h2 i18n>Generate File from Template</h2>
-  <p i18n>
-    Select the template based on which to generate a file for the current record
-    or
+  <p>
+    <span i18n>
+      Select the template based on which to generate a file for the current
+      record or
+    </span>
     <a
       [routerLink]="TemplateExport.route"
       *appDisabledEntityOperation="{
@@ -10,8 +12,9 @@ <h2 i18n>Generate File from Template</h2>
         operation: 'update',
       }"
       matDialogClose
+      i18n
       >configure available templates</a
-    >.
+    >
   </p>
 
   <app-entity-select
diff --git a/src/app/features/todos/recurring-interval/edit-recurring-interval/edit-recurring-interval.component.html b/src/app/features/todos/recurring-interval/edit-recurring-interval/edit-recurring-interval.component.html
index f2d81f6215..589ecce9ea 100644
--- a/src/app/features/todos/recurring-interval/edit-recurring-interval/edit-recurring-interval.component.html
+++ b/src/app/features/todos/recurring-interval/edit-recurring-interval/edit-recurring-interval.component.html
@@ -14,21 +14,19 @@
 
     <mat-option
       (onSelectionChange)="openCustomIntervalSelection($event)"
-      i18n="recurring interval option"
       class="special-option"
     >
       <fa-icon icon="tools" [fixedWidth]="true"></fa-icon>
-      define other interval
+      <span i18n="recurring interval option">define other interval</span>
     </mat-option>
 
     <mat-option
       [value]="undefined"
       (onSelectionChange)="resetSelection()"
-      i18n="recurring interval option"
       class="special-option"
     >
       <fa-icon icon="xmark" [fixedWidth]="true"></fa-icon>
-      does not repeat
+      <span i18n="recurring interval option">does not repeat</span>
     </mat-option>
   </mat-select>