Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Wizard: Edit public forms #2271

Closed
9 tasks done
sleidig opened this issue Mar 1, 2024 · 3 comments · Fixed by #2682
Closed
9 tasks done

Setup Wizard: Edit public forms #2271

sleidig opened this issue Mar 1, 2024 · 3 comments · Fixed by #2682
Assignees
Labels
Client: by X Client: _codo released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Feature new user-facing feature

Comments

@sleidig
Copy link
Member

sleidig commented Mar 1, 2024

Public forms (e.g. https://demo.aam-digital.com/public-form/test) need a drag&drop admin interface similar to the way users can already edit the entity details view (with the AdminEntityDetailsComponent).

From a user's perspective, the following requirements / user stories are involved:
As an admin user, I can ...

  • list all available "Public Forms" in an admin view
  • create/read/update/delete PublicFormConfigs
  • use an intuitive, visual UI to preview & edit the config for a selected Public Form
    • editing fields using the same drag&drop editor available for designing an Entity Details View (in AdminEntityDetailsComponent)
    • editing other details like title, url, description and entity type in additional config form fields (similar to the AdminEntityGeneralSettingsComponent)
  • edit related Public Forms for the current entity type when viewing its AdminEntityComponent  #2708

From a technical perspective, the new Admin UI feature needs to manage valid PublicFormConfig entities. The PublicFormComponent displays these and should ideally not require any changes for this Admin UI implementation. However, if you identify ways to make the config format more simple or suitable, adaptions can be discussed.

Suggested implementation steps (to be adjusted & extended):

  • improve PublicFormConfig format to use FieldGroup rather than string[]: Public Forms should support dynamic prefilled / default values #2401
  • Create a new AdminPublicFormComponent component that displays a form to edit a PublicFormConfig object (may not be needed if we can rely on the EntityDetails system in a smart way)
  • make the new admin component available from the UI as another section in AdminEntity, which can list all PublicForms for that entity type, maybe similar to AdminEntityTypesComponent
@sleidig sleidig added Type: Feature new user-facing feature Client: by X labels Mar 1, 2024
@sleidig sleidig added this to the Setup Wizard milestone Mar 1, 2024
@github-project-automation github-project-automation bot moved this to Triage / Analysis in All Tasks & Issues Mar 1, 2024
@sleidig sleidig moved this from Triage / Analysis to Todo (ready for work) in All Tasks & Issues Apr 17, 2024
@sleidig sleidig moved this from Todo (ready for work) to Triage / Analysis in All Tasks & Issues Apr 18, 2024
@sleidig sleidig moved this to Planned in Feature Roadmap Jul 15, 2024
@sleidig sleidig moved this from Triage / Analysis to In Progress in All Tasks & Issues Oct 21, 2024
@sleidig sleidig self-assigned this Oct 21, 2024
@sleidig
Copy link
Member Author

sleidig commented Oct 21, 2024

This has some overlap with

Suggested there to adjust the config format for PublicFormConfig to be more similar and consistent with Entity Details. Maybe we should first implement those changes, so that the Admin UI discussed here in this issue can be designed for the future-proof config format then, @Abhinegi2

@sleidig sleidig moved this from Planned to In Progress in Feature Roadmap Oct 21, 2024
@sleidig sleidig removed their assignment Oct 21, 2024
@sleidig sleidig moved this from In Progress to Todo (ready for work) in All Tasks & Issues Oct 24, 2024
@sleidig sleidig moved this from In Progress to In Review in All Tasks & Issues Dec 6, 2024
@sleidig sleidig moved this from In Review to In Progress in All Tasks & Issues Dec 6, 2024
@sleidig sleidig moved this from In Progress to In Review in All Tasks & Issues Dec 10, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in All Tasks & Issues Dec 11, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Feature Roadmap Dec 11, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.44.0-master.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Dec 11, 2024
sleidig added a commit that referenced this issue Dec 11, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.44.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Dec 13, 2024
sleidig added a commit that referenced this issue Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: by X Client: _codo released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Feature new user-facing feature
Projects
Archived in project
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants