Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Report calculated at" should display in local timezone #2654

Closed
sleidig opened this issue Nov 11, 2024 · 4 comments · Fixed by #2864
Closed

"Report calculated at" should display in local timezone #2654

sleidig opened this issue Nov 11, 2024 · 4 comments · Fixed by #2864
Assignees
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)

Comments

@sleidig
Copy link
Member

sleidig commented Nov 11, 2024

Describe the bug
Currently the Reports View loads previous calculations and displays the time the result was calculated on:

This report was calculated at: 11.11.2024 14:46

However, this time is not displayed in the local time of the user at the moment. This must reflect local time.

To reproduce:

  1. Visit the "Reports" section (in a system where server-side reports are enabled): https://dev.aam-digital.net/report
  2. Execute a server-side (mode: "sql") report (e.g. in dev system select "Beneficiary (Individuals) [SQL]" report)
  3. See the description text above the results once the calculation is finished and compare the time (it is not in current time-zone)
@github-project-automation github-project-automation bot moved this to Triage / Analysis in All Tasks & Issues Nov 11, 2024
@sleidig sleidig moved this from Triage / Analysis to Todo (ready for work) in All Tasks & Issues Feb 7, 2025
@Abhinegi2 Abhinegi2 self-assigned this Feb 13, 2025
@Abhinegi2 Abhinegi2 moved this from Todo (ready for work) to Planned (current "sprint") in All Tasks & Issues Feb 13, 2025
@Abhinegi2 Abhinegi2 moved this from Planned (current "sprint") to In Progress in All Tasks & Issues Feb 13, 2025
@Abhinegi2 Abhinegi2 moved this from In Progress to Todo (ready for work) in All Tasks & Issues Feb 13, 2025
@Abhinegi2 Abhinegi2 moved this from Todo (ready for work) to Planned (current "sprint") in All Tasks & Issues Feb 13, 2025
@sleidig sleidig removed the Type: Bug label Feb 13, 2025
@Abhinegi2 Abhinegi2 moved this from Planned (current "sprint") to In Progress in All Tasks & Issues Feb 17, 2025
@Abhinegi2 Abhinegi2 moved this from In Progress to Planned (current "sprint") in All Tasks & Issues Feb 17, 2025
@Abhinegi2 Abhinegi2 moved this from Planned (current "sprint") to In Progress in All Tasks & Issues Feb 17, 2025
@Abhinegi2
Copy link
Contributor

@sleidig after investigating, I found that "Report calculated at" comes from the endDate value, retrieved from the backend's report API. To display "Report calculated at" in the local timezone, I’m taking the following approach:

  1. Create a timezone-pipe component to convert datetime to the local timezone.
  2. Integrate it with the ReportingComponent.
  3. Add test cases to ensure correct timezone conversion.

also, let me know if you have any alternative approaches or suggestions.

@sleidig
Copy link
Member Author

sleidig commented Feb 18, 2025

Can you check if there are such pipes already available? (possibly Date pipe has some way to support it)
Seems like a good approach overall.

(tests probably sufficient in the pipe without the need to re-test in reporting-component as logic is only within new/existing pipe's implementation)

@Abhinegi2 Abhinegi2 moved this from In Progress to Functional Review in All Tasks & Issues Feb 18, 2025
@sleidig sleidig moved this from Functional Review to Done in All Tasks & Issues Feb 18, 2025
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.46.3-master.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Feb 18, 2025
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.47.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants