Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field " Applicable Entity type" should be marked as mandatory field in Add new export template screen #2703

Closed
george-neha opened this issue Dec 3, 2024 · 4 comments · Fixed by #2845
Closed

Field " Applicable Entity type" should be marked as mandatory field in Add new export template screen #2703

george-neha opened this issue Dec 3, 2024 · 4 comments · Fixed by #2845
Assignees
@Abhinegi2
Labels
released on @master managed by CI (semantic-release)

Comments

@george-neha
Copy link

Field " Applicable Entity type" should be marked as mandatory field in Add new export template screen.
Currently if this field is blank, the file attachment does not get updated.

Steps:

  1. Click on a child/beneficiary
  2. Click on the three dot menu and select "Generate File"
    Image
  3. Click on "configure available templates"
  4. In the "export template" window, click on "Add new"
  5. The field " Applicable Entity type" should be marked as mandatory.
@george-neha george-neha moved this to Triage / Analysis in All Tasks & Issues Dec 3, 2024
@sleidig sleidig moved this from Triage / Analysis to Todo (ready for work) in All Tasks & Issues Feb 7, 2025
@Abhinegi2 Abhinegi2 moved this from Todo (ready for work) to In Progress in All Tasks & Issues Feb 10, 2025
@Abhinegi2 Abhinegi2 mentioned this issue Feb 10, 2025
Merged
1 task
@Abhinegi2
Copy link
Contributor

@george-neha could you test the above-mentioned issue here https://pr-2845.aam-digital.net/

@Abhinegi2 Abhinegi2 moved this from In Progress to Functional Review in All Tasks & Issues Feb 10, 2025
@george-neha
Copy link
Author

@Abhinegi2 Can you show a similar message (see the screenshot below) for mandatory fields? "This field is required"

Image

@george-neha george-neha moved this from Functional Review to In Progress in All Tasks & Issues Feb 10, 2025
@Abhinegi2
Copy link
Contributor

@george-neha updated! can you check now?

@Abhinegi2 Abhinegi2 moved this from In Progress to Functional Review in All Tasks & Issues Feb 10, 2025
@george-neha george-neha moved this from Functional Review to Technical Review in All Tasks & Issues Feb 10, 2025
sleidig pushed a commit that referenced this issue Feb 10, 2025
@Abhinegi2
fix: make applicable entity types required for Export Template config…
58a2238 
…urations (#2845)

and display a proper form validation error

closes #2703
@github-project-automation github-project-automation bot moved this from Technical Review to Done in All Tasks & Issues Feb 10, 2025
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.46.3-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abhinegi2 Abhinegi2

Labels
released on @master managed by CI (semantic-release)
Projects
All Tasks & Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add required validation for applicableForEntityTypes field Aam-Digital/ndb-core
4 participants
@sleidig @aam-digital-ci @Abhinegi2 @george-neha