Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download of reports as .csv format broken #2783

Closed
sleidig opened this issue Jan 9, 2025 · 2 comments · Fixed by #2854
Closed

Download of reports as .csv format broken #2783

sleidig opened this issue Jan 9, 2025 · 2 comments · Fixed by #2854
Assignees
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)

Comments

@sleidig
Copy link
Member

sleidig commented Jan 9, 2025

Describe the bug
When downloading a report result as .csv the output format is forcing all data into a single column, putting addtional headers "Name,Value" on top of everything. The download for the old client-side reports work correctly but the server-side calculated reports (ReportConfig.mode = "sql") have this issue

Sample csv output (broken):

Name,Value
"eventStartDate: 2024-12-01, eventEndDate: 2024-12-03, eventStatus: Implemented, eventType: Traini..."

To reproduce:

  1. Visit the "Reports" section (in a system where server-side reports are enabled): https://dev.aam-digital.net/report
  2. Execute a server-side (mode: "sql") report (e.g. in dev system select "Beneficiary (Individuals) [SQL]" report)
  3. Click "Download" and try to open the file in a spreadsheet application (does not show columns as expected)

Suggested Implementation Approach:

  1. Write unit tests for SqlReportService.getCsv() to have an easy way for testing without having to run the whole backend report server
  2. change the return type of SqlReportService.getCsv() to something more specific than any
  3. Make corrections to the getCsv method
  4. Check about the formats for the two version of sql reports that we have (v2 has some special structure for nesting - get support from @tomwwinter who originally implemented this, if needed)
@github-project-automation github-project-automation bot moved this to Triage / Analysis in All Tasks & Issues Jan 9, 2025
@sleidig sleidig moved this from Triage / Analysis to Todo (ready for work) in All Tasks & Issues Feb 7, 2025
@Abhinegi2 Abhinegi2 self-assigned this Feb 13, 2025
@Abhinegi2 Abhinegi2 moved this from Todo (ready for work) to In Progress in All Tasks & Issues Feb 13, 2025
@Abhinegi2 Abhinegi2 moved this from In Progress to Planned (current "sprint") in All Tasks & Issues Feb 13, 2025
@sleidig sleidig removed the Type: Bug label Feb 13, 2025
@Abhinegi2 Abhinegi2 moved this from Planned (current "sprint") to In Progress in All Tasks & Issues Feb 17, 2025
@Abhinegi2 Abhinegi2 moved this from In Progress to Technical Review in All Tasks & Issues Feb 17, 2025
@sleidig sleidig moved this from Technical Review to In Progress in All Tasks & Issues Feb 17, 2025
@Abhinegi2 Abhinegi2 moved this from In Progress to Technical Review in All Tasks & Issues Feb 18, 2025
@github-project-automation github-project-automation bot moved this from Technical Review to Done in All Tasks & Issues Feb 18, 2025
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.46.3-master.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Feb 18, 2025
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.47.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants