Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Atum Context, by getting existing partitioning from DB - retrieve Measures and AdditionalData for a given partitioning #120

Closed
lsulak opened this issue Nov 13, 2023 · 1 comment · Fixed by #167
Closed

Get Atum Context, by getting existing partitioning from DB - retrieve Measures and AdditionalData for a given partitioning #120

lsulak opened this issue Nov 13, 2023 · 1 comment · Fixed by #167
Assignees
@TebaleloS
Labels
enhancement New feature or request Server Issues touching the server part of the project

Comments

@lsulak
Copy link
Collaborator

lsulak commented Nov 13, 2023 •
edited by benedeki
Loading

Background

It's needed that the endpoint returns actual data.

Feature

What the ticket says, see the endpoint related to create partitioning event.

Proposed Solution [Optional]

Solution Ideas:

  1. Create Fa-DB classes for runs.get_partitioning_measures and runs.get_partitioning_additional_data DB functions
  2. Call them in PartitioningController (PartitioningController.createPartitioningIfNotExists)

Depends on #169
@lsulak lsulak added enhancement New feature or request DB Issues touching the Database part of the project Server Issues touching the server part of the project labels Nov 13, 2023
@benedeki benedeki moved this from 🆕 To groom to 🔖 Sprint in CPS small repos project Mar 6, 2024
@benedeki benedeki removed the DB Issues touching the Database part of the project label Mar 6, 2024
TebaleloS added a commit that referenced this issue Mar 11, 2024
@TebaleloS
Fixes #120 - Added class to call partitioning measures function
74af153
TebaleloS added a commit that referenced this issue Mar 11, 2024
@TebaleloS
Merge branch 'master' into feature/#120-retrieve-Measures-and-Additio…
74993c0 
…nalData-for-a-given-partitioning
TebaleloS added a commit that referenced this issue Mar 12, 2024
@TebaleloS
Fixes #120 - Removed status 16 option from the DB function associated…
9b8dc52 
… with the partitioning
TebaleloS added a commit that referenced this issue Mar 12, 2024
@TebaleloS
Merge remote-tracking branch 'origin/feature/#120-retrieve-Measures-a…
b0949ba 
…nd-AdditionalData-for-a-given-partitioning' into feature/#120-retrieve-Measures-and-AdditionalData-for-a-given-partitioning
@benedeki benedeki added the dependent The item depends on some other open item (Issue or PR) label Mar 13, 2024
TebaleloS added a commit that referenced this issue Mar 19, 2024
@TebaleloS
Fixes #120 - Changed measures function definitions
daa1a16
TebaleloS added a commit that referenced this issue Mar 19, 2024
@TebaleloS
Fixes #120 - defined the class to communicate with get_partitioning_a…
9680a1b 
…dditional_data function
TebaleloS added a commit that referenced this issue Mar 19, 2024
@TebaleloS
Fixes #120 - implementing the repository of get_partitioning_addition…
ff6edb5 
…al_data function
TebaleloS added a commit that referenced this issue Mar 19, 2024
@TebaleloS
Fixes #120 - Calling getPartioningAdditionalData of the repo in the s…
086525e 
…ervice
TebaleloS added a commit that referenced this issue Mar 19, 2024
@TebaleloS
Fixes #120 - Calling getPartioningAdditionalData of the repo in the s…
52449d3 
…ervice
TebaleloS added a commit that referenced this issue Mar 19, 2024
@TebaleloS
Fixes #120 - added value parameters
57a1fd7
TebaleloS added a commit that referenced this issue Mar 20, 2024
@TebaleloS
Merge branch 'master' into feature/#120-retrieve-Measures-and-Additio…
6d7145b 
…nalData-for-a-given-partitioning

# Conflicts:
#	server/src/main/scala/za/co/absa/atum/server/Main.scala
#	server/src/main/scala/za/co/absa/atum/server/api/controller/PartitioningController.scala
#	server/src/main/scala/za/co/absa/atum/server/api/repository/PartitioningRepository.scala
#	server/src/main/scala/za/co/absa/atum/server/api/service/PartitioningService.scala
TebaleloS added a commit that referenced this issue Mar 20, 2024
@TebaleloS
Fixes #120 - Merged master
1896eba
TebaleloS added a commit that referenced this issue Mar 26, 2024
@TebaleloS
Fixes #120 - refactored the controller added computation method in th…
ac6aa3a 
…e service
TebaleloS added a commit that referenced this issue Mar 26, 2024
@TebaleloS
Fixes #120 - refactored the controller added computation method in th…
94703b8 
…e service
TebaleloS added a commit that referenced this issue Mar 26, 2024
@TebaleloS
Fixes #120 - changed type from error response to service error
3b05824
TebaleloS added a commit that referenced this issue Mar 26, 2024
@TebaleloS
Fixes #120 - Changed inheritance from service trat to implementation
c063480
TebaleloS added a commit that referenced this issue Apr 2, 2024
@TebaleloS
Fixes #120 - Fixing bugs
c5c5a28
TebaleloS added a commit that referenced this issue Apr 2, 2024
@TebaleloS
Fixes #120 - Fixing type mismatch
e6e48c9
TebaleloS added a commit that referenced this issue Apr 2, 2024
@TebaleloS
Fixes #120 - removed unused imports
f43f67f
TebaleloS added a commit that referenced this issue Apr 4, 2024
@TebaleloS
Fixes #120 - Adding implicit conversion
baf89a2
TebaleloS added a commit that referenced this issue Apr 4, 2024
@TebaleloS
Fixes #120 - Added package object
c86914b
@benedeki benedeki moved this from 🔖 Sprint to 🏗 In progress in CPS small repos project Apr 11, 2024
@TebaleloS TebaleloS mentioned this issue Apr 12, 2024
Merged
@benedeki benedeki moved this from 🏗 In progress to 👀 In review in CPS small repos project Apr 15, 2024
TebaleloS added a commit that referenced this issue Apr 15, 2024
@TebaleloS
Fixes #120 - Applying GitHub comments
d75b5dd
TebaleloS added a commit that referenced this issue Apr 17, 2024
@TebaleloS
Fixes #120 - Applying GitHub comments
a6f09d3
TebaleloS added a commit that referenced this issue Apr 17, 2024
@TebaleloS
Fixes #120 - merging master
4475aaa
TebaleloS added a commit that referenced this issue Apr 17, 2024
@TebaleloS
Fixes #120 - Fixing bugs
c4f2aaa
TebaleloS added a commit that referenced this issue Apr 17, 2024
@TebaleloS
Fixes #120 - Fixing repository test cases bugs
5bfe34b
TebaleloS added a commit that referenced this issue Apr 17, 2024
@TebaleloS
Fixes #120 - removing println
975648b
TebaleloS added a commit that referenced this issue Apr 18, 2024
@TebaleloS
Fixes #120 - Fixing bugs from ControllerSpec
ed67783
TebaleloS added a commit that referenced this issue Apr 18, 2024
@TebaleloS
Fixes #120 - Adding more items to measure sequence
a8348a6
TebaleloS added a commit that referenced this issue Apr 18, 2024
@TebaleloS
Fixes #120 - Removing dead code
604d518
TebaleloS added a commit that referenced this issue Apr 18, 2024
@TebaleloS
Closes #120
1d31880
TebaleloS added a commit that referenced this issue Apr 19, 2024
@TebaleloS
Close #120 - Applying GitHub comments
9c5bb99
TebaleloS added a commit that referenced this issue Apr 19, 2024
@TebaleloS
Close #120 - Addressing GitHub comments
44c3664
TebaleloS added a commit that referenced this issue Apr 25, 2024
@TebaleloS
Testing #120 db integration
388492a
lsulak added a commit that referenced this issue Apr 25, 2024
@lsulak
#120: ignoring status-related fields for now, not supported like this…
450a45f 
… by current fa-db version (but will be soon)
TebaleloS added a commit that referenced this issue Apr 26, 2024
@TebaleloS
Testing #120 db integration
7e30a62
TebaleloS added a commit that referenced this issue Apr 26, 2024
@TebaleloS
Closes #120 - Cleaning unwanted code lines
d1b6f7c
TebaleloS added a commit that referenced this issue Apr 26, 2024
@TebaleloS
Closes #120 - Fixing the build
42e9604
TebaleloS added a commit that referenced this issue Apr 26, 2024
@TebaleloS
Closes #120 - Fixing the build
66af419
TebaleloS added a commit that referenced this issue Apr 26, 2024
@TebaleloS
Closes #120 - Fixing the tests
31dea31
TebaleloS added a commit that referenced this issue Apr 26, 2024
@TebaleloS
Closes #120 - Fixing the tests
ef537a5
TebaleloS added a commit that referenced this issue Apr 26, 2024
@TebaleloS
Closes #120 - Fixing the tests cases
30c5f3f
lsulak added a commit that referenced this issue Apr 26, 2024
@lsulak
Merge remote-tracking branch 'refs/remotes/origin/master' into feature/…
c41a50f 
…#120-retrieve-Measures-and-AdditionalData-for-a-given-partitioning

# Conflicts:
#	database/src/main/postgres/flows/V1.7.4__flows.alter.ddl
#	database/src/test/scala/za/co/absa/atum/database/runs/GetPartitioningAdditionalDataTest.scala
#	database/src/test/scala/za/co/absa/atum/database/runs/GetPartitioningMeasuresTest.scala
TebaleloS added a commit that referenced this issue Apr 30, 2024
@TebaleloS @salamonpavel
@lsulak @benedeki
Get Atum Context, by getting existing partitioning from DB - retrieve…
4d83d79 
… Measures and AdditionalData for a given partitioning #120 (#167)

* Fixes #120 - Added class to call partitioning measures function

* Fixes #120 - Removed status 16 option from the DB function associated with the partitioning

* Fixes #120 - Changed measures function definitions

* Fixes #120 - defined the class to communicate with get_partitioning_additional_data function

* Fixes #120 - implementing the repository of get_partitioning_additional_data function

* Fixes #120 - Calling getPartioningAdditionalData of the repo in the service

* Fixes #120 - Calling getPartioningAdditionalData of the repo in the service

* Fixes #120 - added value parameters

* Fixes #120 - Merged master

* Fixes #120 - refactored the controller added computation method in the service

* Fixes #120 - refactored the controller added computation method in the service

* Fixes #120 - changed type from error response to service error

* Fixes #120 - Changed inheritance from service trat to implementation

* Fixes #120 - Fixing bugs

* Fixes #120 - Fixing type mismatch

* Fixes #120 - removed unused imports

* Fixes #120 - Adding implicit conversion

* Fixes #120 - Added package object

* implicits needed for Read instance derivation

* Fixes #120 - Fixing bugs in PartitioningRepositorySpec

* Fixes #120 - removed dead code in PartitioningRepositorySpec

* Fixes #120 - fixing type mismatch in PartitioningRepositorySpec

* Fixes #120 - Adding test cases in PartitioningRepositorySpec

* Fixes #120 - Adding test cases

* Fixes #120 - Adding test cases for db function

* Fixes #120 - Adding and fixing test cases for db function

* Fixes #120 - removing dead code

* Fixes #120 - refactoring function name

* Fixes #120 - Applying GitHub comments

* Fixes #120 - Applying GitHub comments

* Fixes #120 - Fixing bugs

* Fixes #120 - Fixing repository test cases bugs

* Fixes #120 - removing println

* Fixes #120 - Fixing bugs from ControllerSpec

* Fixes #120 - Adding more items to measure sequence

* Fixes #120 - Removing dead code

* Closes #120

* Close #120 - Applying GitHub comments

* Close #120 - Addressing GitHub comments

* Testing #120 db integration

* Closes #120 - Cleaning unwanted code lines

* Closes #120 - Fixing the build

* Closes #120 - Fixing the build

* Closes #120 - Fixing the tests

* Closes #120 - Fixing the tests

* Closes #120 - Fixing the tests cases

* fixing the balta tests

* * Fixing jacoco_check.yml setup (hopefully)

* * Decreasing overall coverage req

* jacoco excludes

* added tests, decreased coverage level, added jacoco exclusions

---------

Co-authored-by: Pavel Salamon <[email protected]>
Co-authored-by: Ladislav Sulak <[email protected]>
Co-authored-by: David Benedeki <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in CPS small repos project Apr 30, 2024
TebaleloS added a commit that referenced this issue May 7, 2024
@TebaleloS @benedeki
Create DB function to get all checkpoint data of a partitioning :#189 (…
f98828b 
…#191)

* Fixes #189 - Define and implemented a db function to return the checkpoint

* Fixes #189 - Modifying a db function

* Fixes #189 - Modifying a db function

* Fixes #189 - Adding test cases

* Fixes #189 - Added two input fields to the db function

* Fixes #189 - Fixing type mismatch

* Testing #120 db integration

* Fixes #189 - Adding test cases

* Fixes #189 - Changing back the details of flows.flows

* Fixes #189 - Implementing GitHub comments

* Update database/src/main/postgres/runs/V1.8.3__get_partitioning_checkpoint.sql

Co-authored-by: David Benedeki <[email protected]>

* Update database/src/main/postgres/runs/V1.8.3__get_partitioning_checkpoint.sql

Co-authored-by: David Benedeki <[email protected]>

* Update database/src/main/postgres/runs/V1.8.3__get_partitioning_checkpoint.sql

Co-authored-by: David Benedeki <[email protected]>

* Update database/src/main/postgres/runs/V1.8.3__get_partitioning_checkpoint.sql

Co-authored-by: David Benedeki <[email protected]>

* Fixes #189 - Addressing GitHub comments

* Closes #189

* Closes #189 - Addressing GitHub comments

* Closes #189 - Addressing GitHub comments

---------

Co-authored-by: David Benedeki <[email protected]>
TebaleloS added a commit that referenced this issue Jun 13, 2024
@TebaleloS @salamonpavel
Server endpoints v2 returning the checkpoins data of a partitioning: …
5ab72ea 
…190 (#194)

* Fixes #189 - Define and implemented a db function to return the checkpoint

* Fixes #189 - Modifying a db function

* Fixes #189 - Modifying a db function

* Fixes #189 - Adding test cases

* Fixes #189 - Added two input fields to the db function

* Fixes #189 - Fixing type mismatch

* Testing #120 db integration

* Fixes #189 - Adding test cases

* Fixes #189 - Changing back the details of flows.flows

* Fixes #189 - Implementing GitHub comments

* Fixes #190 - defined the dto to submit

* Update V1.7.1__flows.alter.ddl

* Delete database/src/main/postgres/runs/V1.8.3__get_partitioning_checkpoint.sql

* Update GetPartitioningMeasuresTest.scala

* Delete database/src/test/scala/za/co/absa/atum/database/runs/GetPartitioningCheckpoints.scala

* Fixees #190 - Added checkpoint query resultDTO, GetPartitioningCheckpoints class and its object

* Fixes #190 - implementing get checkpoints functionality in the repository

* Fixes #190 - renamed CheckpointDTO to CheckpointSubmitDTO

* Fixes #190 - Implementing partitioningCheckpoint service

* Fixes #190 - Implementing partitioningCheckpoint in the partitioning related classes.

* Fixes #190 - Implementing partitioningCheckpoint in the partitioning related classes.

* Fixes #190 - fixing controller

* Fixes #190 - Adding layers

* Fixes #190 - Adding doobie implicit

* Fixes #190 - Fixing the build

* Fixes #190 - removing unwanted layer from checkpoint repository

* Fixes #190 - adding mock layer from PartitioningRepositorySpec

* Fixes #190 - adding the implicits for the added dto's and defining the endpoint.

* Fixes #190 - defining current version

* Fixes #190 - Fixing type mismatch

* Fixes #190 - Implementing DTO instances

* Fixes #190 - Implementing DTO instances

* Fixes #190 - adding CheckpointMeasurements model

* Fixes #190 - adding CheckpointMeasurements test

* Read[CheckpointMeasurements]

* Saving changes

* Fixes #190 - Read[CheckpointMeasurements] test

* Fixes #190 - transforming CheckpointMeasurements to CheckpointDTO

* removing default values on output

* partitioning checkpoint test

* partitioning checkpoint test repository

* partitioning checkpoint test for service

* partitioning checkpoint test controller

* partitioning checkpoint test controller

* removed the mapError from getPartitioningCheckpoints

* Fixing getPartitioningCheckpoints test and implements GitHub suggestions

* Fixing merging conflicts

* Removing unused import

* implementing GitHub comments

* implementing GitHub comments in service

* implementing GitHub comments

* Fixing the build

* Fixing V1.8.3__get_partitioning_checkpoints.sql fields

* Fixing service test cases

* Fixing measure_columns to measured_columns

* Changing from object CheckpointFromDBObject to CheckpointFromDB

* Changing from object CheckpointFromDBObject to CheckpointFromDB

* Defining partitioningJson in a common way

* Implementing GitHub comments

---------

Co-authored-by: Pavel Salamon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TebaleloS TebaleloS

Labels
enhancement New feature or request Server Issues touching the server part of the project
Projects
CPS small repos project
Archived in project
Milestone
No milestone
3 participants
@lsulak @benedeki @TebaleloS