Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call GetOrCreatePartitioning endpoint and process the response #122

Closed
benedeki opened this issue Nov 15, 2023 · 0 comments · Fixed by #124
Closed

Call GetOrCreatePartitioning endpoint and process the response #122

benedeki opened this issue Nov 15, 2023 · 0 comments · Fixed by #124
Assignees
@cerveada
Labels
enhancement New feature or request
Milestone
MVP: Atum agent

Comments

@benedeki
Copy link
Contributor

benedeki commented Nov 15, 2023 •
edited
Loading

Background

A clear and concise description of where the limitation lies.

Feature

Within the HttpDispatcher.getOrCreateAtumContext call the actual endpoint on the server (/api/v1//createPartitioning) and process the response into the return value.

Proposed Solution

  • Feel free to rename the function (in the Dispatcher to be similar to end-point name)
  • Consider, it might be useful/needed to change the return type to support asynchronicity
@benedeki benedeki converted this from a draft issue Nov 15, 2023
@benedeki benedeki added this to the MVP: Atum agent milestone Nov 15, 2023
@benedeki benedeki added the enhancement New feature or request label Nov 15, 2023
cerveada added a commit that referenced this issue Nov 16, 2023
@cerveada
#122 createPartitioning from client to server functionality
2c07a0b 
- also fix Future/CompletableFuture issue on server
@cerveada cerveada mentioned this issue Nov 16, 2023
Merged
cerveada added a commit that referenced this issue Nov 16, 2023
@cerveada
#122 createPartitioning from client to server functionality
a446fb2 
- also fix Future/CompletableFuture issue on server
@github-project-automation github-project-automation bot moved this from 🔖 Sprint to ✅ Done in CPS small repos project Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cerveada cerveada

Labels
enhancement New feature or request
Projects
CPS small repos project
Archived in project
Milestone
MVP: Atum agent
Development

Successfully merging a pull request may close this issue.

#122 createPartitioning from client to server functionality AbsaOSS/atum-service
2 participants
@cerveada @benedeki