Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests are in the 'tests' package where package private functions cannot be tested #157

Open
jirifilip opened this issue Feb 10, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@jirifilip
Copy link
Collaborator

Describe the bug

Some of the tests are located in the za.co.absa.pramen.{core,runner,extras}.tests package whereas some of them are located in za.co.absa.pramen.{core,runner,extras}. In the za.co.absa.pramen.core.{core,runner,extras}.tests, package private functions cannot be tested because the name of the test package is different than the name of the package of the class under test.

Expected behavior

The tests should be under za.co.absa.pramen.{core,runner,extras} package. The package private functions can be then tested.

Context

Pramen/pramen-py version: 1.2.2

@jirifilip jirifilip added the bug Something isn't working label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant